Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upComment explaining constellation panic for recv #10294
Closed
Conversation
highfive
commented
Mar 30, 2016
|
|
…se of recv failure.
asajeffrey
force-pushed the
asajeffrey:document-constellation-recv-panic
branch
from
9f7d502
to
6dab59f
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 1, 2016
…r=jdm
Comment explaining constellation panic for recv
Added comment explaining why the constellation still panics in the case of recv failure. Also changed `.unwrap()` to `.expect("reason")` so we can track down panics more easily.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10294)
<!-- Reviewable:end -->
|
@bors-servo r- force clean |
|
@bors-servo clean |
|
Sorry, closing this seems to be the only way to make homu do its job. |
|
Do I need to resubmit this PR? |
|
Please do |
bors-servo
added a commit
that referenced
this pull request
Apr 2, 2016
…r=jdm Comment explaining constellation panic for recv A retry of #10294, which was closed due to homu issues. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10343) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedMar 30, 2016
Added comment explaining why the constellation still panics in the case of recv failure. Also changed
.unwrap()to.expect("reason")so we can track down panics more easily.This change is