Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Document::cookie correctly for cookie-averse documents. #10304

Merged
merged 1 commit into from Apr 1, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Mar 31, 2016

This change is Reviewable

@highfive
Copy link

highfive commented Mar 31, 2016

Heads up! This PR modifies the following files:

  • @jgraham: tests/wpt/metadata/html/dom/documents/resource-metadata-management/document-cookie.html.ini
  • @KiChjang: components/script/dom/document.rs
@nox
Copy link
Member

nox commented Mar 31, 2016

@bors-servo r+

Could you file a follow-up E-Easy issue about moving the URL function to rust-url? Thanks.

@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2016

📌 Commit 3c6cc64 has been approved by nox

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Mar 31, 2016

Filed servo/rust-url#182; will see if Simon agrees

@bors-servo
Copy link
Contributor

bors-servo commented Apr 1, 2016

Testing commit 3c6cc64 with merge 7d79df4...

bors-servo added a commit that referenced this pull request Apr 1, 2016
Implement Document::cookie correctly for cookie-averse documents.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10304)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 1, 2016

@bors-servo bors-servo merged commit 3c6cc64 into servo:master Apr 1, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the Ms2ger:cookie-averse branch Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.