Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report errors from ScriptPort trait methods. #10312

Merged
merged 1 commit into from Apr 1, 2016
Merged

Report errors from ScriptPort trait methods. #10312

merged 1 commit into from Apr 1, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Mar 31, 2016

This change is Reviewable
@jdm @Ms2ger
Report errors from ScriptPort trait methods.
Loading status checks…
2cfedc7
@highfive
Copy link

highfive commented Mar 31, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/script_thread.rs, components/script/dom/xmlhttprequest.rs, components/script/dom/dedicatedworkerglobalscope.rs
@highfive
Copy link

highfive commented Mar 31, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Mar 31, 2016

From #8600.

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 31, 2016

📌 Commit 2cfedc7 has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Apr 1, 2016

⌛ Testing commit 2cfedc7 with merge 6056b16...
bors-servo added a commit that referenced this pull request Apr 1, 2016
@bors-servo
Auto merge of #10312 - servo:ScriptPort, r=Ms2ger
Loading status checks…
6056b16 
Report errors from ScriptPort trait methods.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10312)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 1, 2016

☀️ Test successful - android, arm32, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, status-appveyor
@bors-servo bors-servo merged commit 2cfedc7 into master Apr 1, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Apr 1, 2016
Merged
@Ms2ger Ms2ger deleted the ScriptPort branch Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@metajack metajack

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @bors-servo @metajack @jdm
You can’t perform that action at this time.