Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `get_*` on getters as per RFC 0344. #10327

Merged
merged 1 commit into from Apr 2, 2016
Merged

Remove `get_*` on getters as per RFC 0344. #10327

merged 1 commit into from Apr 2, 2016

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Apr 1, 2016

https://github.com/rust-lang/rfcs/blob/master/text/0344-conventions-galore.md#gettersetter-apis

#6224

This change is Reviewable
@frewsxcv
Remove `get_*` on getters as per RFC 0344.
Loading status checks…
bf4db40 
https://github.com/rust-lang/rfcs/blob/master/text/0344-conventions-galore.md#gettersetter-apis

#6224
@highfive
Copy link

highfive commented Apr 1, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/document.rs, components/script/webdriver_handlers.rs, components/script/dom/htmlcollection.rs, components/script/dom/node.rs, components/script/dom/element.rs, components/script/dom/htmlimageelement.rs, components/script/script_thread.rs, components/script/dom/window.rs, components/script/devtools.rs
@highfive
Copy link

highfive commented Apr 1, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 1, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 1, 2016

📌 Commit bf4db40 has been approved by Ms2ger
@frewsxcv
Copy link
Member Author

frewsxcv commented Apr 1, 2016

@bors-servo r=ms2ger p=-1

Demoting because this is not very important
@bors-servo
Copy link
Contributor

bors-servo commented Apr 1, 2016

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #10315
@bors-servo
Copy link
Contributor

bors-servo commented Apr 1, 2016

📌 Commit bf4db40 has been approved by ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Apr 2, 2016

⌛ Testing commit bf4db40 with merge 0760e56...
bors-servo added a commit that referenced this pull request Apr 2, 2016
@bors-servo
Auto merge of #10327 - frewsxcv:get-prefix, r=ms2ger
Loading status checks…
0760e56 
Remove `get_*` on getters as per RFC 0344.

https://github.com/rust-lang/rfcs/blob/master/text/0344-conventions-galore.md#gettersetter-apis

#6224

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10327)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 2, 2016

☀️ Test successful - android, arm32, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, status-appveyor
@bors-servo bors-servo merged commit bf4db40 into servo:master Apr 2, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@frewsxcv frewsxcv deleted the frewsxcv:get-prefix branch Apr 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@frewsxcv @highfive @Ms2ger @bors-servo
You can’t perform that action at this time.