Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip printing the backtrace for RecvError/SendError #10329

Merged
merged 3 commits into from Apr 5, 2016
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Prev

Add option for printing full backtraces

  • Loading branch information
Manishearth committed Apr 5, 2016
commit a2c82a03ba613a32d6ad8e31111178083ab7da7b
@@ -201,6 +201,9 @@ pub struct Opts {

// Which rendering API to use.
pub render_api: RenderApi,

// don't skip any backtraces on panic
pub full_backtraces: bool,
}

fn print_usage(app: &str, opts: &Options) {
@@ -291,6 +294,9 @@ pub struct DebugOptions {
/// Use multisample antialiasing in WebRender.
pub use_msaa: bool,

// don't skip any backtraces on panic
pub full_backtraces: bool,

}


@@ -326,6 +332,7 @@ impl DebugOptions {
"disable-vsync" => debug_options.disable_vsync = true,
"wr-stats" => debug_options.webrender_stats = true,
"msaa" => debug_options.use_msaa = true,
"full-backtraces" => debug_options.full_backtraces = true,
"" => {},
_ => return Err(option)
};
@@ -373,6 +380,7 @@ pub fn print_debug_usage(app: &str) -> ! {
"Disable vsync mode in the compositor to allow profiling at more than monitor refresh rate");
print_option("wr-stats", "Show WebRender profiler on screen.");
print_option("msaa", "Use multisample antialiasing in WebRender.");
print_option("full-backtraces", "Print full backtraces for all errors");

println!("");

@@ -515,6 +523,7 @@ pub fn default_opts() -> Opts {
use_msaa: false,
render_api: DEFAULT_RENDER_API,
profile_dir: None,
full_backtraces: false,
}
}

@@ -795,6 +804,7 @@ pub fn from_cmdline_args(args: &[String]) -> ArgumentParsingResult {
webrender_stats: debug_options.webrender_stats,
use_msaa: debug_options.use_msaa,
profile_dir: opt_match.opt_str("profile-dir"),
full_backtraces: debug_options.full_backtraces,
};

set_defaults(opts);
@@ -3,6 +3,7 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

use ipc_channel::ipc::IpcSender;
use opts;
use serde::Serialize;
use std::borrow::ToOwned;
use std::io::{Write, stderr};
@@ -17,6 +18,11 @@ pub fn spawn_named<F>(name: String, f: F)
{
let builder = thread::Builder::new().name(name);

if opts::get().full_backtraces {
builder.spawn(f).unwrap();
return;
}

let f_with_handler = move || {
let hook = take_handler();

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.