New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip printing the backtrace for RecvError/SendError #10329
Merged
+47
−1
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.
Loading status checks…
Skip printing the backtrace for RecvError/SendError
We currently get tons of useless backtraces clogging up the output when we have a panic cascade. This adds a handler that outputs a single line when a thread panics due to a sender or receiver hanging up, since this is almost always due to a panic cascade.
- Loading branch information
commit ed3f7f5818156229b7af4e5b1c4834745ffa7342
| @@ -5,16 +5,41 @@ | ||
| use ipc_channel::ipc::IpcSender; | ||
| use serde::Serialize; | ||
| use std::borrow::ToOwned; | ||
| use std::io::{Write, stderr}; | ||
| use std::panic::{PanicInfo, take_handler, set_handler}; | ||
| use std::sync::mpsc::Sender; | ||
| use std::thread; | ||
| use std::thread::Builder; | ||
| use thread_state; | ||
|
|
||
| #[allow(unused_must_use)] | ||
Manishearth
Author
Member
|
||
| pub fn spawn_named<F>(name: String, f: F) | ||
| where F: FnOnce() + Send + 'static | ||
| { | ||
| let builder = thread::Builder::new().name(name); | ||
| builder.spawn(f).unwrap(); | ||
|
|
||
| let f_with_handler = move || { | ||
| let hook = take_handler(); | ||
|
|
||
| let new_handler = move |info: &PanicInfo| { | ||
| let payload = info.payload(); | ||
| if let Some(s) = payload.downcast_ref::<String>() { | ||
| if s.contains("SendError") { | ||
Manishearth
Author
Member
|
||
| write!(stderr(), "Thread \"{}\" panicked with an unwrap of `SendError` (backtrace skipped)\n", | ||
| thread::current().name().unwrap_or("<unknown thread>")); | ||
| return; | ||
| } else if s.contains("RecvError") { | ||
| write!(stderr(), "Thread \"{}\" panicked with an unwrap of `RecvError` (backtrace skipped)\n", | ||
| thread::current().name().unwrap_or("<unknown thread>")); | ||
| return; | ||
| } | ||
| } | ||
| hook(&info); | ||
| }; | ||
| set_handler(new_handler); | ||
| f(); | ||
| }; | ||
|
|
||
| builder.spawn(f_with_handler).unwrap(); | ||
| } | ||
|
|
||
| /// An abstraction over `Sender<T>` and `IpcSender<T>`, for use in | ||
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Why this addition?