Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment explaining constellation panic for recv #10343

Merged

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Apr 1, 2016

A retry of #10294, which was closed due to homu issues.


This change is Reviewable

…se of recv failure.
@highfive
Copy link

highfive commented Apr 1, 2016

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 1, 2016

@bors-servo r=jdm

@bors-servo
Copy link
Contributor

bors-servo commented Apr 1, 2016

📌 Commit 6dab59f has been approved by jdm

@KiChjang
Copy link
Member

KiChjang commented Apr 1, 2016

@bors-servo p=-1

Putting this in lower priority so that our homu queue doesn't clog up.

@bors-servo
Copy link
Contributor

bors-servo commented Apr 2, 2016

Testing commit 6dab59f with merge 85f9f96...

bors-servo added a commit that referenced this pull request Apr 2, 2016
…r=jdm

Comment explaining constellation panic for recv

A retry of #10294, which was closed due to homu issues.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10343)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 2, 2016

@bors-servo bors-servo merged commit 6dab59f into servo:master Apr 2, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.