Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIssue #10368: Implemented Uniform4iv and Uniform4i #10369
Conversation
highfive
commented
Apr 2, 2016
highfive
commented
Apr 2, 2016
|
Looks good, but needs a PR to wr_traits :) -S-awaiting-review +S-needs-code-changes Review status: 0 of 5 files reviewed at latest revision, 1 unresolved discussion. components/script/dom/webglrenderingcontext.rs, line 978 [r1] (raw file): Comments from Reviewable |
|
components/script/dom/webglrenderingcontext.rs, line 978 [r1] (raw file): Comments from Reviewable |
|
Review status: 0 of 5 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed. components/script/dom/webglrenderingcontext.rs, line 978 [r1] (raw file): Comments from Reviewable |
Added Uniform4i Blocking servo/servo#10369
|
Once servo/webrender_traits#32 lands, you can run |
|
@bors-servo: r+ |
|
|
Issue #10368: Implemented Uniform4iv and Uniform4i Uniform4iv can make use of Uniform4i, so I implemented both. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10369) <!-- Reviewable:end -->
|
|
autrilla commentedApr 2, 2016
Uniform4iv can make use of Uniform4i, so I implemented both.
This change is