Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement nodeName on Attr #10372

Merged
merged 1 commit into from Apr 4, 2016
Merged

Implement nodeName on Attr #10372

merged 1 commit into from Apr 4, 2016
+10 −80

Conversation

@dzbarsky
Copy link
Member

dzbarsky commented Apr 2, 2016

This change is Reviewable
@highfive
Copy link

highfive commented Apr 2, 2016

Heads up! This PR modifies the following files:

  • @jgraham: tests/wpt/metadata/html/dom/interfaces.html.ini, tests/wpt/metadata/dom/nodes/Document-createAttribute.html.ini, tests/wpt/metadata/dom/nodes/Element-removeAttributeNS.html.ini, tests/wpt/metadata/dom/nodes/attributes.html.ini
  • @KiChjang: components/script/dom/attr.rs, components/script/dom/webidls/Attr.webidl
@dzbarsky
Copy link
Member Author

dzbarsky commented Apr 2, 2016

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Apr 2, 2016

⌛ Trying commit 223a17e with merge c4f7b8e...
bors-servo added a commit that referenced this pull request Apr 2, 2016
@bors-servo
Auto merge of #10372 - dzbarsky:rmAttrNS, r=<try>
Loading status checks…
c4f7b8e 
Implement nodeName on Attr
@bors-servo
Copy link
Contributor

bors-servo commented Apr 2, 2016

💔 Test failed - mac-rel-wpt
@dzbarsky dzbarsky force-pushed the dzbarsky:rmAttrNS branch from 223a17e to 22debcd Apr 2, 2016
@highfive highfive removed the S-tests-failed label Apr 2, 2016
@dzbarsky
Copy link
Member Author

dzbarsky commented Apr 2, 2016

@bors-servo retry
@dzbarsky
Copy link
Member Author

dzbarsky commented Apr 3, 2016

Not sure what travis is complaining about, any thoughts?
@jdm
Copy link
Member

jdm commented Apr 3, 2016

The CI is complaining about a test being deleted without the manifest being updated.
@dzbarsky
Implement nodeName on Attr
Loading status checks…
8cbcdfb
@dzbarsky dzbarsky force-pushed the dzbarsky:rmAttrNS branch from 22debcd to 8cbcdfb Apr 3, 2016
@dzbarsky
Copy link
Member Author

dzbarsky commented Apr 3, 2016

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Apr 3, 2016

⌛ Trying commit 8cbcdfb with merge de1877d...
bors-servo added a commit that referenced this pull request Apr 3, 2016
@bors-servo
Auto merge of #10372 - dzbarsky:rmAttrNS, r=<try>
Loading status checks…
de1877d 
Implement nodeName on Attr

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10372)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 3, 2016

💔 Test failed - status-appveyor
@dzbarsky
Copy link
Member Author

dzbarsky commented Apr 4, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 4, 2016

⌛ Trying commit 8cbcdfb with merge aaac600...
bors-servo added a commit that referenced this pull request Apr 4, 2016
@bors-servo
Auto merge of #10372 - dzbarsky:rmAttrNS, r=<try>
Loading status checks…
aaac600 
Implement nodeName on Attr

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10372)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 4, 2016

☀️ Test successful - android, arm32, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, status-appveyor
@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 4, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 4, 2016

📌 Commit 8cbcdfb has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Apr 4, 2016

⌛ Testing commit 8cbcdfb with merge 8a9ef01...
bors-servo added a commit that referenced this pull request Apr 4, 2016
@bors-servo
Auto merge of #10372 - dzbarsky:rmAttrNS, r=Ms2ger
Loading status checks…
8a9ef01 
Implement nodeName on Attr

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10372)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 4, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Apr 4, 2016 

Ran 4648 tests finished in 319.0 seconds.
  • 4647 ran as expected. 1364 tests skipped.
  • 1 tests timed out unexpectedly

Tests with unexpected results:
  ▶ TIMEOUT [expected CRASH] /webstorage/storage_setitem.html
  │ 
  │ Xlib:  extension "XFree86-VidModeExtension" missing on display ":0".
  │ thread 'ScriptThread PipelineId { namespace_id: PipelineNamespaceId(0), index: PipelineIndex(0) }' panicked at 'Found an unpaired surrogate in a DOM string. If you see this in real web content, please comment on https://github.com/servo/servo/issues/6564 Use `-Z replace-surrogates` on the command line to make this non-fatal.', /home/servo/buildbot/slave/linux-rel/build/components/util/non_geckolib.rs:83
  │ stack backtrace:
  │    1:     0x7ffdf9c7c1b0 - sys::backtrace::tracing::imp::write::h495bc662e480d01f2cv
  │    2:     0x7ffdf9c810ff - panicking::default_handler::_$u7b$$u7b$closure$u7d$$u7d$::closure.44522
  │    3:     0x7ffdf9c80d78 - panicking::default_handler::h4e73712d1e927dfeH0z
  │    4:     0x7ffdf9c6ab1c - sys_common::unwind::begin_unwind_inner::h0e1be209f5e9e87dg2t
  │    5:     0x7ffdf94b6b5f - sys_common::unwind::begin_unwind::h5644377430908265868
  │    6:     0x7ffdf94b8a03 - non_geckolib::jsstring_to_str::hbe4eefbe554e46aaNNa
  │    7:     0x7ffdf86865bf - dom::bindings::conversions::jsid_to_str::ha3334b092c04778blFc
  │    8:     0x7ffdf882ef6f - dom::bindings::codegen::Bindings::StorageBinding::getOwnPropertyDescriptor::ha50d68c52013b721t2T
  │    9:     0x7ffdf95e5e81 - _ZNK22ForwardingProxyHandler24getOwnPropertyDescriptorEP9JSContextN2JS6HandleIP8JSObjectEENS3_I4jsidEENS2_13MutableHandleI20JSPropertyDescriptorEE
  │   10:     0x7ffdf9a83323 - _ZNK2js16BaseProxyHandler3setEP9JSContextN2JS6HandleIP8JSObjectEES7_NS4_I4jsidEENS3_13MutableHandleINS3_5ValueEEERNS3_14ObjectOpResultE
  │                         at /home/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/proxy/BaseProxyHandler.cpp:86
  │   11:     0x7ffdf95e5858 - _ZNK22ForwardingProxyHandler3setEP9JSContextN2JS6HandleIP8JSObjectEES6_NS3_I4jsidEENS2_13MutableHandleINS2_5ValueEEERNS2_14ObjectOpResultE
  │   12:     0x7ffdf9a9c960 - _ZN2js5Proxy3setEP9JSContextN2JS6HandleIP8JSObjectEES7_NS4_I4jsidEENS3_13MutableHandleINS3_5ValueEEERNS3_14ObjectOpResultE
  │                         at /home/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/proxy/Proxy.cpp:326
  │   13:     0x7ffdf970a759 - _ZN2js11PutPropertyEP9JSContextN2JS6HandleIP8JSObjectEENS3_I4jsidEENS2_13MutableHandleINS2_5ValueEEEb
  │                         at /home/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/NativeObject.h:1450
  │                         at /home/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/jsobj.h:905
  │   14:     0x7ffdf96f2a3a - _ZL9InterpretP9JSContextRN2js8RunStateE
  │                         at /home/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/Interpreter.cpp:1406
  │                         at /home/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/Interpreter.cpp:2531
  │   15:     0x7ffdf96fd75c - _ZN2js9RunScriptEP9JSContextRNS_8RunStateE
  │                         at /home/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/Interpreter.cpp:452
  │   16:     0x7ffdf96fd9dd - _ZN2js6InvokeEP9JSContextN2JS8CallArgsENS_14MaybeConstructE
  │                         at /home/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/Interpreter.cpp:521
  └   17:     0x7ffdf9a42b62 - _ZN2js9fun_applyEP9JSContextjPN2JS5ValueE
@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 4, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 4, 2016

⌛ Testing commit 8cbcdfb with merge ca3d120...
bors-servo added a commit that referenced this pull request Apr 4, 2016
@bors-servo
Auto merge of #10372 - dzbarsky:rmAttrNS, r=Ms2ger
Loading status checks…
ca3d120 
Implement nodeName on Attr

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10372)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 4, 2016

☀️ Test successful - android, arm32, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, status-appveyor
@bors-servo bors-servo merged commit 8cbcdfb into servo:master Apr 4, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@dzbarsky @highfive @bors-servo @jdm @Ms2ger @KiChjang @SimonSapin
You can’t perform that action at this time.