Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed sources of panic from piepline.rs. #10423

Merged
merged 1 commit into from Apr 8, 2016
Merged

Removed sources of panic from piepline.rs. #10423

merged 1 commit into from Apr 8, 2016
+59 −29

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Apr 5, 2016

Fixes #10422.

This change is Reviewable
@emilio
Copy link
Member

emilio commented Apr 5, 2016

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

components/compositing/pipeline.rs, line 135 [r1] (raw file):
nit: "Pipeline layout"

Comments from Reviewable
@asajeffrey
Copy link
Member Author

asajeffrey commented Apr 5, 2016

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

components/compositing/pipeline.rs, line 135 [r1] (raw file):
Done.

Comments from Reviewable
@jdm jdm mentioned this pull request Apr 7, 2016
Merged
@wafflespeanut
Copy link
Member

wafflespeanut commented Apr 7, 2016

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2016

📌 Commit 0e6ff74 has been approved by emilio
@jdm
Copy link
Member

jdm commented Apr 7, 2016

@bors-servo: r-
I'd prefer to see this squashed first.
@jdm jdm added S-needs-squash and removed S-awaiting-merge labels Apr 7, 2016
@wafflespeanut
Copy link
Member

wafflespeanut commented Apr 7, 2016

Oops, sorry, didn't notice :)
@asajeffrey
Removed sources of panic from piepline.rs.
Loading status checks…
01b6e4a
@asajeffrey asajeffrey force-pushed the asajeffrey:constellation-pipeline-hardening branch from 0e6ff74 to 01b6e4a Apr 8, 2016
@asajeffrey
Copy link
Member Author

asajeffrey commented Apr 8, 2016

Squashed.
@emilio
Copy link
Member

emilio commented Apr 8, 2016

@bors-servo: r=emilio,jdm
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2016

📌 Commit 01b6e4a has been approved by emilio,jdm
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2016

⌛ Testing commit 01b6e4a with merge bcac1a3...
bors-servo added a commit that referenced this pull request Apr 8, 2016
@bors-servo
Auto merge of #10423 - asajeffrey:constellation-pipeline-hardening, r…
Loading status checks…
bcac1a3 
…=emilio,jdm

Removed sources of panic from piepline.rs.

Fixes #10422.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10423)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2016

💔 Test failed - linux-rel
@asajeffrey
Copy link
Member Author

asajeffrey commented Apr 8, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 01b6e4a into servo:master Apr 8, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@jdm jdm mentioned this pull request Apr 13, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
A-constellation I-panic S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
@asajeffrey @emilio @wafflespeanut @bors-servo @jdm @mbrubeck @KiChjang @highfive
You can’t perform that action at this time.