Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement WebGLRenderingContext.getActiveUniform() #10433

Merged
merged 1 commit into from Apr 6, 2016

Conversation

@saurvs
Copy link
Contributor

saurvs commented Apr 6, 2016

Fixes #10397


This change is Reviewable

@highfive
Copy link

highfive commented Apr 6, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/webglrenderingcontext.rs, components/script/dom/webidls/WebGLRenderingContext.webidl, components/script/dom/webglprogram.rs
  • @emilio: components/script/dom/webglrenderingcontext.rs, components/script/dom/webglprogram.rs
@highfive
Copy link

highfive commented Apr 6, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member

emilio commented Apr 6, 2016

Thanks! Looks great, but you still have to update some more lockfiles :)

./mach cargo-update -p webrender_traits should do it if i'm not wrong.

@emilio emilio assigned emilio and unassigned jdm Apr 6, 2016
@saurvs
Copy link
Contributor Author

saurvs commented Apr 6, 2016

I did that, but it re-added byteorder 0.4.2, and there's also byteorder 0.5.1, so ./mach test-tidy complains.

@saurvs
Copy link
Contributor Author

saurvs commented Apr 6, 2016

I think we need to upgrade every crate servo depends on to byteorder 0.5.1

@emilio
Copy link
Member

emilio commented Apr 6, 2016

@saurvs: we can add it to the exception list if there's a lot of crates, but updating the others might be preferred.

@saurvs
Copy link
Contributor Author

saurvs commented Apr 6, 2016

Well there are 7 crates bincode image immeta ipc-channel jpeg-decoder wayland-window websocket, so I guess I can open PR's for them and see if they get updated soon.

@emilio
Copy link
Member

emilio commented Apr 6, 2016

Some of them are not from the servo org, so... What if we open a tracking issue, add it to the exception list temporarily, open a bunch of PRs to update it, and when that issue gets solved (that is, all those PRs merged), we remove it from the exception list?

@jdm Would you agree with this? Or should we open PRs and wait?

@saurvs
Copy link
Contributor Author

saurvs commented Apr 6, 2016

Oh yeah, I just tried bumping the version for byteorder in image, and it looks like 0.5 breaks a lot. So I guess it might take a while to update all the crates.

@jdm
Copy link
Member

jdm commented Apr 6, 2016

Yeah, if it's blocking us from other useful work we can add an exception for it.

@saurvs
Copy link
Contributor Author

saurvs commented Apr 6, 2016

Ok done.

@emilio emilio mentioned this pull request Apr 6, 2016
7 of 7 tasks complete
@emilio
Copy link
Member

emilio commented Apr 6, 2016

Filled #10437 to keep track of this.

@bors-servo: r+

@bors-servo
Copy link
Contributor

bors-servo commented Apr 6, 2016

📌 Commit 56eef10 has been approved by emilio

@bors-servo
Copy link
Contributor

bors-servo commented Apr 6, 2016

Testing commit 56eef10 with merge 4cc241c...

bors-servo added a commit that referenced this pull request Apr 6, 2016
Implement WebGLRenderingContext.getActiveUniform()

Fixes #10397

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10433)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 6, 2016

@bors-servo bors-servo merged commit 56eef10 into servo:master Apr 6, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.