Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement WebGLRenderingContext.getActiveUniform() #10433
Conversation
highfive
commented
Apr 6, 2016
highfive
commented
Apr 6, 2016
|
Thanks! Looks great, but you still have to update some more lockfiles :)
|
|
I did that, but it re-added |
|
I think we need to upgrade every crate servo depends on to |
|
@saurvs: we can add it to the exception list if there's a lot of crates, but updating the others might be preferred. |
|
Well there are 7 crates |
|
Some of them are not from the servo org, so... What if we open a tracking issue, add it to the exception list temporarily, open a bunch of PRs to update it, and when that issue gets solved (that is, all those PRs merged), we remove it from the exception list? @jdm Would you agree with this? Or should we open PRs and wait? |
|
Oh yeah, I just tried bumping the version for |
|
Yeah, if it's blocking us from other useful work we can add an exception for it. |
|
Ok done. |
|
Filled #10437 to keep track of this. @bors-servo: r+ |
|
|
Implement WebGLRenderingContext.getActiveUniform() Fixes #10397 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10433) <!-- Reviewable:end -->
|
|
saurvs commentedApr 6, 2016
Fixes #10397
This change is