Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webgl: Implement the pending texImage2D overload, and add more validation #10443

Merged
merged 12 commits into from Apr 22, 2016

Commits on Apr 19, 2016

  1. webgl: Implement the pending texImage2D overload, and add more valida…

    …tion
    
    This is a large-ish refactor of the Texture2D code, but it should be
    easier to read and of course more correct.
    
    I tried to annotate every error condition with a spec paragraph.
    emilio committed Apr 19, 2016
  2. webgl: Refactor WebGLProgram::link

    This makes it more correct, since we don't blindly send the Link
    command. It's not observable though.
    emilio committed Apr 19, 2016
  3. webgl: Remove active_uniform related validation.

    It's broken for uniform arrays, since uniform.id() stops being the index
    then.
    
    We need to add a more complex integration with angle for this to ever
    be correct.
    
    Unfortunately the ANGLE part that we should touch is C++, and it has
    destructors, so we need to hook destructors there, and I can't do it
    right now.
    emilio committed Apr 19, 2016

Commits on Apr 20, 2016

  1. webgl: Reset bound buffer when appropiate in BufferData

    This makes the test bufferDataBadArgs pass appropiately.
    emilio committed Apr 20, 2016
  2. webgl: Fix filling a non-zero level

    You can fill a level > 0 as long as the width and height values are
    power of two, so the previous test was bogus.
    emilio committed Apr 20, 2016
  3. webgl: texture: Make initialize only mark as initialized the current …

    …face
    
    Also refactor a bit the code, and remove the unused `is_initialized`
    flag.
    emilio committed Apr 20, 2016
  4. webgl: Fix a few typos in comments

    emilio committed Apr 20, 2016
  5. webgl: tests: Mark the bufferDataBadArgs test as passing

    It now passes consistently.
    emilio committed Apr 20, 2016
  6. webgl: tests: Update expectations of tests

    This tests previously "passed", because they used the texImage2D
    overload we're adding now.
    
    Since that overload previously caused a TypeError, these tests were
    never run in the first place.
    emilio committed Apr 20, 2016
You can’t perform that action at this time.