Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webgl: Implement the pending texImage2D overload, and add more validation #10443

Merged
merged 12 commits into from Apr 22, 2016
+606 −128
Merged

webgl: Implement the pending texImage2D overload, and add more validation #10443

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
87e112d
webgl: Implement the pending texImage2D overload, and add more valida…
emilio Apr 6, 2016
5eb5993
webgl: Add test for Texture2d's ArrayBufferView overload
emilio Apr 6, 2016
c807cab
webgl: Validate that the texture should be power of two if the level is
emilio Apr 19, 2016
f470ad0
webgl: Refactor WebGLProgram::link
emilio Apr 19, 2016
6a15c2f
webgl: Remove active_uniform related validation.
emilio Apr 19, 2016
bc08762
webgl: Rename UniformType to UniformSetterType and hoist to the bottom
emilio Apr 19, 2016
1ad7f73
webgl: Reset bound buffer when appropiate in BufferData
emilio Apr 20, 2016
21e2f97
webgl: Fix filling a non-zero level
emilio Apr 20, 2016
d152c7f
webgl: texture: Make initialize only mark as initialized the current …
emilio Apr 20, 2016
f6f1e37
webgl: Fix a few typos in comments
emilio Apr 20, 2016
764fac7
webgl: tests: Mark the bufferDataBadArgs test as passing
emilio Apr 20, 2016
9fff9d4
webgl: tests: Update expectations of tests
emilio Apr 20, 2016
File filter...
Filter file types
Clear filters
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Prev
Loading status checks…

webgl: tests: Update expectations of tests 

This tests previously "passed", because they used the texImage2D
overload we're adding now.

Since that overload previously caused a TypeError, these tests were
never run in the first place.
  • Loading branch information
@emilio
emilio committed Apr 20, 2016
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
commit 9fff9d45d1108fcb2a594feb091e0f64d2cab7e4
3 tests/wpt/metadata/webgl/conformance-1.0.3/conformance/limits/gl-min-textures.html.ini
View file
Open in desktop
@@ -3,3 +3,6 @@
[WebGL test #0: successfullyParsed should be true (of type boolean). Was undefined (of type undefined).]
expected: FAIL

[WebGL test #1: successfullyParsed should be true (of type boolean). Was undefined (of type undefined).]
expected: FAIL

3 tests/wpt/metadata/webgl/conformance-1.0.3/conformance/renderbuffers/feedback-loop.html.ini
View file
Open in desktop
@@ -3,3 +3,6 @@
[WebGL test #0: successfullyParsed should be true (of type boolean). Was undefined (of type undefined).]
expected: FAIL

[WebGL test #1: successfullyParsed should be true (of type boolean). Was undefined (of type undefined).]
expected: FAIL

3 tests/wpt/metadata/webgl/conformance-1.0.3/conformance/textures/texture-mips.html.ini
View file
Open in desktop
@@ -6,3 +6,6 @@
[WebGL test #3: successfullyParsed should be true (of type boolean). Was undefined (of type undefined).]
expected: FAIL

[WebGL test #11: successfullyParsed should be true (of type boolean). Was undefined (of type undefined).]
expected: FAIL

3 tests/wpt/metadata/webgl/conformance-1.0.3/conformance/textures/texture-npot.html.ini
View file
Open in desktop
@@ -3,3 +3,6 @@
[WebGL test #1: successfullyParsed should be true (of type boolean). Was undefined (of type undefined).]
expected: FAIL

[WebGL test #4: successfullyParsed should be true (of type boolean). Was undefined (of type undefined).]
expected: FAIL

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.