Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate ipc-channel for two important bug fixes #10447
Merged
Conversation
This fixes #10260 by pulling in servo/ipc-channel#61 (fix receive for messages close to packet size) and servo/ipc-channel#62 (properly handle ENOBUFS); where the latter is not critical per se, as there was a workaround already -- but that workaround aggrevated the first bug, resulting in the urgent issue... This bump requires a tidy override for `uuid`: `ipc-channel` was updated to `uuid 0.2` in servo/ipc-channel#63 (don't know why...), while other crates are still with `0.1`. That was blocking this urgent bug fix; and according to a discussion with @mbrubeck on IRC, the override should be OK in this case.
highfive
commented
Apr 6, 2016
|
Heads up! This PR modifies the following files:
|
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 6, 2016
Update ipc-channel for two important bug fixes This fixes #10260 by pulling in servo/ipc-channel#61 (fix receive for messages close to packet size) and servo/ipc-channel#62 (properly handle ENOBUFS); where the latter is not critical per se, as there was a workaround already -- but that workaround aggrevated the first bug, resulting in the urgent issue... This bump requires a tidy override for `uuid`: `ipc-channel` was updated to `uuid 0.2` in servo/ipc-channel#63 (don't know why...), while other crates are still with `0.1`. That was blocking this urgent bug fix; and according to a discussion with @mbrubeck on IRC, the override should be OK in this case. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10447) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
antrik commentedApr 6, 2016
This fixes #10260 by pulling in
servo/ipc-channel#61 (fix receive for messages
close to packet size) and servo/ipc-channel#62
(properly handle ENOBUFS); where the latter is not critical per se, as
there was a workaround already -- but that workaround aggrevated the
first bug, resulting in the urgent issue...
This bump requires a tidy override for
uuid:ipc-channelwas updatedto
uuid 0.2in servo/ipc-channel#63 (don'tknow why...), while other crates are still with
0.1. That was blockingthis urgent bug fix; and according to a discussion with @mbrubeck on
IRC, the override should be OK in this case.
This change is