Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #10456 Remove unused import warnings in HTMLLegendElement #10463

Merged
merged 1 commit into from Apr 8, 2016
Merged

Issue #10456 Remove unused import warnings in HTMLLegendElement #10463

merged 1 commit into from Apr 8, 2016

Conversation

@amarant
Copy link
Contributor

amarant commented Apr 7, 2016

Fixes #10456.

This change is Reviewable
@amarant
Issue #10456 Remove unused import warnings in HTMLLegendElement
Loading status checks…
4dedd46
@highfive
Copy link

highfive commented Apr 7, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/htmllegendelement.rs
@highfive
Copy link

highfive commented Apr 7, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@KiChjang
Copy link
Member

KiChjang commented Apr 7, 2016

@bors-servo r+

Thanks!
@KiChjang KiChjang assigned KiChjang and unassigned larsbergstrom Apr 7, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2016

📌 Commit 4dedd46 has been approved by KiChjang
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2016

⌛ Testing commit 4dedd46 with merge cf44a54...
bors-servo added a commit that referenced this pull request Apr 7, 2016
@bors-servo
Auto merge of #10463 - amarant:10456-HTMLLegendElement-warnings, r=Ki…
Loading status checks…
cf44a54 
…Chjang

Issue #10456 Remove unused import warnings in HTMLLegendElement

Fixes #10456.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10463)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2016

💔 Test failed - linux-rel
@wafflespeanut
Copy link
Member

wafflespeanut commented Apr 8, 2016

@bors-servo retry

#10473
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2016

⌛ Testing commit 4dedd46 with merge b6c4f51...
bors-servo added a commit that referenced this pull request Apr 8, 2016
@bors-servo
Auto merge of #10463 - amarant:10456-HTMLLegendElement-warnings, r=Ki…
Loading status checks…
b6c4f51 
…Chjang

Issue #10456 Remove unused import warnings in HTMLLegendElement

Fixes #10456.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10463)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 4dedd46 into servo:master Apr 8, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KiChjang KiChjang

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@amarant @highfive @KiChjang @bors-servo @wafflespeanut @larsbergstrom
You can’t perform that action at this time.