Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix rebasing error #10465
Merged
Fix rebasing error #10465
Conversation
This PR mistakenly removed JIT enabling/disabling by preference: https://github.com/servo/servo/pull/10342/files Look for `get_pref`. I'm putting the missing piece of code into the appropriate place in script_runtime.rs
highfive
commented
Apr 7, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Apr 7, 2016
|
|
|
@bors-servo r+ Thanks! |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 8, 2016
Fix rebasing error This PR mistakenly removed JIT enabling/disabling by preference: https://github.com/servo/servo/pull/10342/files Look for `get_pref`. I'm putting the missing piece of code into the appropriate place in script_runtime.rs r? @KiChjang <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10465) <!-- Reviewable:end -->
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 8, 2016
Fix rebasing error This PR mistakenly removed JIT enabling/disabling by preference: https://github.com/servo/servo/pull/10342/files Look for `get_pref`. I'm putting the missing piece of code into the appropriate place in script_runtime.rs r? @KiChjang <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10465) <!-- Reviewable:end -->
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 8, 2016
Fix rebasing error This PR mistakenly removed JIT enabling/disabling by preference: https://github.com/servo/servo/pull/10342/files Look for `get_pref`. I'm putting the missing piece of code into the appropriate place in script_runtime.rs r? @KiChjang <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10465) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
stjepang commentedApr 7, 2016
This PR mistakenly removed JIT enabling/disabling by preference:
https://github.com/servo/servo/pull/10342/files
Look for
get_pref.I'm putting the missing piece of code into the appropriate place in
script_runtime.rs
r? @KiChjang
This change is