Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mime! macro in fetch methods #10471

Merged
merged 1 commit into from Apr 8, 2016
Merged

Use mime! macro in fetch methods #10471

merged 1 commit into from Apr 8, 2016

Conversation

@KiChjang
Copy link
Member

KiChjang commented Apr 8, 2016

This change is Reviewable
@highfive
Copy link

highfive commented Apr 8, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/net/Cargo.toml, components/net/fetch/methods.rs, components/net/lib.rs
@highfive
Copy link

highfive commented Apr 8, 2016

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!
@KiChjang KiChjang force-pushed the KiChjang:mime-macro branch from c6fcca5 to 4ec7916 Apr 8, 2016
@KiChjang
Copy link
Member Author

KiChjang commented Apr 8, 2016

Needs #10470 first, otherwise this will fail compiling.
@KiChjang KiChjang force-pushed the KiChjang:mime-macro branch 2 times, most recently from d9b271f to b3d9cfa Apr 8, 2016
@KiChjang
Copy link
Member Author

KiChjang commented Apr 8, 2016

Woah, what went wrong on Travis?
@emilio
Copy link
Member

emilio commented Apr 8, 2016

Looks good to me, way easier to read!

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2016

📌 Commit b3d9cfa has been approved by emilio
@emilio emilio assigned emilio and unassigned wafflespeanut Apr 8, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2016

⌛ Testing commit b3d9cfa with merge 80a1db4...
bors-servo added a commit that referenced this pull request Apr 8, 2016
@bors-servo
Auto merge of #10471 - KiChjang:mime-macro, r=emilio
Loading status checks…
80a1db4 
Use mime! macro in fetch methods

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10471)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2016

💔 Test failed - linux-dev
@emilio
Copy link
Member

emilio commented Apr 8, 2016

@KiChjang Lockfiles need to be updated, then r=me
@KiChjang
Use mime! macro in fetch methods
Loading status checks…
32f309c
@KiChjang KiChjang force-pushed the KiChjang:mime-macro branch from b3d9cfa to 32f309c Apr 8, 2016
@KiChjang
Copy link
Member Author

KiChjang commented Apr 8, 2016

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2016

📌 Commit 32f309c has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2016

⌛ Testing commit 32f309c with merge 217e450...
bors-servo added a commit that referenced this pull request Apr 8, 2016
@bors-servo
Auto merge of #10471 - KiChjang:mime-macro, r=emilio
Loading status checks…
217e450 
Use mime! macro in fetch methods

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10471)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member Author

KiChjang commented Apr 8, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 32f309c into servo:master Apr 8, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@KiChjang KiChjang deleted the KiChjang:mime-macro branch Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@KiChjang @highfive @emilio @bors-servo @wafflespeanut
You can’t perform that action at this time.