Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: add build status badges #10482

Merged
merged 1 commit into from Apr 15, 2016
Merged

readme: add build status badges #10482

merged 1 commit into from Apr 15, 2016

Conversation

@matthiaskrgr
Copy link
Contributor

matthiaskrgr commented Apr 8, 2016

@perlun
Copy link
Contributor

perlun commented Apr 8, 2016

Awesome - thanks Matthias!

@jdm
Copy link
Member

jdm commented Apr 8, 2016

Thank you for submitting this and linking to the demo! I'm not convinced that this is very useful for Servo, however, since we have automation that prevents code from merging if any part of the build or test process fails on any supported platform. The fact that the appveyor builds are failing right now is a problem with the appveyor setup, rather than an indication that Servo can't be built on Windows in its current state.

@matthiaskrgr
Copy link
Contributor Author

matthiaskrgr commented Apr 8, 2016

Hmm.
Part of the motivation of this patch was that master branch was actually failing on travis a few hours ago.
https://travis-ci.org/servo/servo/builds

Besides it might be good for users to see that the project cares about stability and that the master branch is in buildable state.

I can hide the appveyor badge if you want.

@jdm
Copy link
Member

jdm commented Apr 8, 2016

Yeah, the travis situation was an unfortunate mismatch between what runs in .travis.yml and what runs in https://github.com/servo/saltfs/blob/master/buildbot/master/master.cfg (servo/saltfs#216). I remain on the fence about this, so I'll defer to others.

@notriddle
Copy link
Contributor

notriddle commented Apr 8, 2016

There's always options:

Builds always passing!

@matthiaskrgr matthiaskrgr force-pushed the matthiaskrgr:readme branch from c26e267 to 2ba6d39 Apr 9, 2016
@nox nox assigned jdm and unassigned nox Apr 15, 2016
@nox
Copy link
Member

nox commented Apr 15, 2016

Reassigning to @jdm.

@jdm
Copy link
Member

jdm commented Apr 15, 2016

Well, given how often recently we've had failures that are legitimate and indicative of real problems, I'm going to go ahead and merge this. Hopefully they'll stop being necessary soon :)

@bors-servo: r+

@bors-servo
Copy link
Contributor

bors-servo commented Apr 15, 2016

📌 Commit 2ba6d39 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Apr 15, 2016

Testing commit 2ba6d39 with merge f736d8a...

bors-servo added a commit that referenced this pull request Apr 15, 2016
readme: add build status badges

Preview can be seen here:

https://github.com/matthiaskrgr/servo/tree/readme#the-servo-parallel-browser-engine-project

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10482)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 15, 2016

💔 Test failed - linux-rel

@KiChjang
Copy link
Member

KiChjang commented Apr 15, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Apr 15, 2016

Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...

@bors-servo
Copy link
Contributor

bors-servo commented Apr 15, 2016

@bors-servo bors-servo merged commit 2ba6d39 into servo:master Apr 15, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.