Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTake transform:translate into account when computing clipping regions. #10486
Conversation
|
I'm not sure that a general fix would require major changes; we'd just need to compute a bounding box for the transform. |
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 8, 2016
Take transform:translate into account when computing clipping regions. Note that this only works for translation; a more general fix would require major changes to how display lists work. Closes #10431? <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10486) <!-- Reviewable:end -->
|
|
|
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 12, 2016
Take transform:translate into account when computing clipping regions. Note that this only works for translation; a more general fix would require major changes to how display lists work. Closes #10431? <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10486) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
|
|
|
|
|
@bors-servo: retry
|
bors-servo
added a commit
that referenced
this pull request
Apr 13, 2016
Take transform:translate into account when computing clipping regions. Note that this only works for translation; a more general fix would require major changes to how display lists work. Closes #10431? <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10486) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
notriddle commentedApr 8, 2016
Note that this only works for translation; a more general fix would
require major changes to how display lists work.
Closes #10431?
This change is