Issue #10491 add HTMLInputElement attributes that reflect content ide… #10505

amarant · 2016-04-09T22:26:08Z

…ntically

it uses a new version of string-cache servo/string-cache#148

This change is

highfive · 2016-04-09T22:26:11Z

Heads up! This PR modifies the following files:

@bholley: components/style/Cargo.toml
@KiChjang: components/script/dom/webidls/HTMLInputElement.webidl, components/script/Cargo.toml, components/script/dom/htmlinputelement.rs

wafflespeanut · 2016-04-10T02:51:56Z

./components/script/dom/htmlinputelement.rs:309: link to WHATWG may break in the future, use this format instead: https://html.spec.whatwg.org/multipage/#attr-input-accept

./components/script/dom/htmlinputelement.rs:312: link to WHATWG may break in the future, use this format instead: https://html.spec.whatwg.org/multipage/#attr-input-accept

./components/script/dom/htmlinputelement.rs:315: link to WHATWG may break in the future, use this format instead: https://html.spec.whatwg.org/multipage/#attr-input-alt

./components/script/dom/htmlinputelement.rs:317: trailing whitespace

./components/script/dom/htmlinputelement.rs:318: link to WHATWG may break in the future, use this format instead: https://html.spec.whatwg.org/multipage/#attr-input-alt

./components/script/dom/htmlinputelement.rs:321: link to WHATWG may break in the future, use this format instead: https://html.spec.whatwg.org/multipage/#attr-input-dirName

./components/script/dom/htmlinputelement.rs:323: trailing whitespace

./components/script/dom/htmlinputelement.rs:324: link to WHATWG may break in the future, use this format instead: https://html.spec.whatwg.org/multipage/#attr-input-dirName

KiChjang · 2016-04-10T07:14:48Z

I think those #attr-input-* links shoul really be #dom-input-* links instead.

KiChjang · 2016-04-10T07:48:53Z

Also, are the changes to tests/wpt/metadata/html/dom/reflection-forms.html.ini intended?

jdm · 2016-04-10T13:32:23Z

It's a test that setting properties of DOM APIs to certain values is properly reflected by the equivalent getter, so it seems likely to me.

amarant · 2016-04-10T17:05:40Z

I've fixed the urls, and tidy errors.

KiChjang · 2016-04-10T20:01:12Z

tests/wpt/mozilla/meta/mozilla/preferences.html.ini

-    dom.testbinding.preference_value.space_string_test:test1 test2,
-    dom.testbinding.preference_value.quote_string_test:"test1 test2",
-    ]
+  prefs: [dom.testbinding.preference_value.falsy:false, dom.testbinding.preference_value.truthy:true, dom.testbinding.preference_value.string_empty:, dom.testbinding.preference_value.string_test:test, dom.testbinding.preference_value.space_string_test:test1 test2, dom.testbinding.preference_value.quote_string_test:"test1 test2"]


Why is this changed and set into one line?

Running ./mach update-wpt has some uncommitted changes that result in various formatting updates. This is one of them, though they should probably happen in a different PR.

The thing is that I made the edit to format the ini file when I added the prefs in another PR, but it seems update-wpt format it in 1 line, maybe we should let it that way.

KiChjang · 2016-04-10T20:01:42Z

tests/wpt/metadata/XMLHttpRequest/data-uri.htm.ini

@@ -1,6 +1,5 @@
 [data-uri.htm]
  type: testharness
-


Not sure why this is a good change.

This is the result of update-wpt, others doing the same command will have the same result, should I re-add the deleted line ?

Personally, I think it's fine to leave it in. Ideally it'd be in a separate PR, but not a big deal at all. I'll let @KiChjang decide though

KiChjang · 2016-04-10T21:08:13Z

Forget about the changes, apparently update-wpt caused some formatting updates that I wasn't aware of. Thanks!

@bors-servo r+

bors-servo · 2016-04-10T21:08:14Z

📌 Commit cd57f54 has been approved by KiChjang

bors-servo · 2016-04-10T21:08:16Z

⌛ Testing commit cd57f54 with merge b8de0b6...


        Auto merge of #10505 - amarant:10491-HTMLInputElement-attr, r=KiChjang

Issue #10491 add HTMLInputElement attributes that reflect content ide… …ntically it uses a new version of string-cache servo/string-cache#148  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10505)

bors-servo · 2016-04-10T21:44:50Z

💔 Test failed - mac-rel-wpt

frewsxcv · 2016-04-10T22:07:35Z

🎊

Tests with unexpected results:
  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/datetime.html:
  └ PASS [expected FAIL] [date] The min attribute must have a value that is a valid global date and time string

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/datetime.html:
  └ PASS [expected FAIL] [date] The max attribute must have a value that is a valid global date and time string

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/datetime.html:
  └ PASS [expected FAIL] [date] The step attribute must be expressed in seconds

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/datetime.html:
  └ PASS [expected FAIL] [time] The min attribute must have a value that is a valid global date and time string

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/datetime.html:
  └ PASS [expected FAIL] [time] The max attribute must have a value that is a valid global date and time string

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/datetime.html:
  └ PASS [expected FAIL] [time] The step attribute must be expressed in seconds

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/datetime.html:
  └ PASS [expected FAIL] [datetime] The min attribute must have a value that is a valid global date and time string

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/datetime.html:
  └ PASS [expected FAIL] [datetime] The max attribute must have a value that is a valid global date and time string

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/datetime.html:
  └ PASS [expected FAIL] [datetime] The step attribute must be expressed in seconds

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/datetime.html:
  └ PASS [expected FAIL] [month] The min attribute must have a value that is a valid global date and time string

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/datetime.html:
  └ PASS [expected FAIL] [month] The max attribute must have a value that is a valid global date and time string

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/datetime.html:
  └ PASS [expected FAIL] [month] The step attribute must be expressed in seconds

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/datetime.html:
  └ PASS [expected FAIL] [week] The min attribute must have a value that is a valid global date and time string

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/datetime.html:
  └ PASS [expected FAIL] [week] The max attribute must have a value that is a valid global date and time string

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/datetime.html:
  └ PASS [expected FAIL] [week] The step attribute must be expressed in seconds

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/email.html:
  └ PASS [expected FAIL] single_email doesn't have the multiple attribute

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/email.html:
  └ PASS [expected FAIL] multiple_email has the multiple attribute

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/range.html:
  └ PASS [expected FAIL] min attribute support on input element

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/range.html:
  └ PASS [expected FAIL] max attribute support on input element

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/time.html:
  └ PASS [expected FAIL] step attribute on default value check

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/time.html:
  └ PASS [expected FAIL] max  attribute on default value check

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/time.html:
  └ PASS [expected FAIL] min  attribute on default value check

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/time.html:
  └ PASS [expected FAIL] max attribute support on input element

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/time.html:
  └ PASS [expected FAIL] min attribute support on input element

  ▶ Unexpected subtest result in /html/semantics/forms/the-input-element/time.html:
  └ PASS [expected FAIL] step attribute support on input element

amarant · 2016-04-10T22:18:23Z

Ok I should have been more thorough during the wpt test, I will update the ini files. It means that Travis/AppVeyor don't do them ?

frewsxcv · 2016-04-10T22:20:14Z

Correct. Travis and Appveyor currently only run unit and compile tests, not wpt or an other tests:

https://github.com/servo/servo/blob/master/.travis.yml#L15-L16

bors-servo · 2016-04-11T21:47:51Z

☔ The latest upstream changes (presumably #10445) made this pull request unmergeable. Please resolve the merge conflicts.


        Issue #10491 add HTMLInputElement attributes that reflect content ide…

…ntically it uses a new version of string-cache servo/string-cache#148

KiChjang · 2016-04-11T23:12:08Z

@bors-servo r+

bors-servo · 2016-04-11T23:12:10Z

📌 Commit 9b8f183 has been approved by KiChjang

bors-servo · 2016-04-12T00:28:16Z

⌛ Testing commit 9b8f183 with merge 61865f6...


        Auto merge of #10505 - amarant:10491-HTMLInputElement-attr, r=KiChjang

Issue #10491 add HTMLInputElement attributes that reflect content ide… …ntically it uses a new version of string-cache servo/string-cache#148  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10505)

bors-servo · 2016-04-12T01:07:46Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt

highfive assigned larsbergstrom Apr 9, 2016

highfive added the S-awaiting-review label Apr 9, 2016

wafflespeanut added the S-fails-tidy label Apr 10, 2016

KiChjang added S-needs-code-changes and removed S-awaiting-review labels Apr 10, 2016

KiChjang assigned KiChjang and unassigned larsbergstrom Apr 10, 2016

amarant force-pushed the amarant:10491-HTMLInputElement-attr branch from 90c25cf to cd57f54 Apr 10, 2016

highfive added S-awaiting-review and removed S-needs-code-changes labels Apr 10, 2016

KiChjang removed the S-fails-tidy label Apr 10, 2016

KiChjang reviewed Apr 10, 2016
View changes

KiChjang added S-needs-code-changes and removed S-awaiting-review labels Apr 10, 2016

highfive removed the S-needs-code-changes label Apr 10, 2016

highfive added the S-awaiting-merge label Apr 10, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Apr 10, 2016

frewsxcv added the S-needs-code-changes label Apr 10, 2016

amarant force-pushed the amarant:10491-HTMLInputElement-attr branch from cd57f54 to 281115b Apr 11, 2016

highfive added S-awaiting-review and removed S-tests-failed S-needs-code-changes labels Apr 11, 2016

highfive added the S-needs-rebase label Apr 11, 2016

Issue #10491 add HTMLInputElement attributes that reflect content ide…

Loading status checks…

9b8f183

…ntically it uses a new version of string-cache servo/string-cache#148

amarant force-pushed the amarant:10491-HTMLInputElement-attr branch from 281115b to 9b8f183 Apr 11, 2016

highfive added S-awaiting-merge and removed S-awaiting-review S-needs-rebase labels Apr 11, 2016

bors-servo merged commit 9b8f183 into servo:master Apr 12, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Apr 12, 2016

bors-servo mentioned this pull request Apr 12, 2016

Implement GetActiveAttrib #10379

Merged

KiChjang mentioned this pull request Apr 12, 2016

Reflect HTMLInputElement content attributes #10491

Closed

servo / servo

Issue #10491 add HTMLInputElement attributes that reflect content ide… #10505

Issue #10491 add HTMLInputElement attributes that reflect content ide… #10505

amarant commented Apr 9, 2016

highfive commented Apr 9, 2016

wafflespeanut commented Apr 10, 2016

KiChjang commented Apr 10, 2016

KiChjang commented Apr 10, 2016

jdm commented Apr 10, 2016

amarant commented Apr 10, 2016

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

KiChjang commented Apr 10, 2016

bors-servo commented Apr 10, 2016

bors-servo commented Apr 10, 2016

bors-servo commented Apr 10, 2016

frewsxcv commented Apr 10, 2016

amarant commented Apr 10, 2016

frewsxcv commented Apr 10, 2016

bors-servo commented Apr 11, 2016

KiChjang commented Apr 11, 2016

bors-servo commented Apr 11, 2016

bors-servo commented Apr 12, 2016

bors-servo commented Apr 12, 2016

servo / servo

Join GitHub today

Issue #10491 add HTMLInputElement attributes that reflect content ide… #10505

Issue #10491 add HTMLInputElement attributes that reflect content ide… #10505

Conversation

amarant commented Apr 9, 2016

highfive commented Apr 9, 2016

wafflespeanut commented Apr 10, 2016

KiChjang commented Apr 10, 2016

KiChjang commented Apr 10, 2016

jdm commented Apr 10, 2016

amarant commented Apr 10, 2016

This comment has been minimized.

KiChjang Apr 10, 2016

This comment has been minimized.

frewsxcv Apr 10, 2016

This comment has been minimized.

amarant Apr 10, 2016

This comment has been minimized.

KiChjang Apr 10, 2016

This comment has been minimized.

amarant Apr 10, 2016

This comment has been minimized.

frewsxcv Apr 10, 2016

KiChjang commented Apr 10, 2016

bors-servo commented Apr 10, 2016

bors-servo commented Apr 10, 2016

bors-servo commented Apr 10, 2016

frewsxcv commented Apr 10, 2016

amarant commented Apr 10, 2016

frewsxcv commented Apr 10, 2016

bors-servo commented Apr 11, 2016

KiChjang commented Apr 11, 2016

bors-servo commented Apr 11, 2016

bors-servo commented Apr 12, 2016

bors-servo commented Apr 12, 2016