Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 'align' IDL attribute on '<hr>'. #10535

Merged
merged 2 commits into from Apr 12, 2016
Merged

Implement 'align' IDL attribute on '<hr>'. #10535

merged 2 commits into from Apr 12, 2016

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Apr 11, 2016

This change is Reviewable
frewsxcv added 2 commits Apr 11, 2016
@frewsxcv
Implement 'align' IDL attribute on '<hr>'.
bd74844
@frewsxcv
Add WPT test for 'align' attribute on '<hr>'.
Loading status checks…
3ebf43a
@highfive
Copy link

highfive commented Apr 11, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/webidls/HTMLHRElement.webidl, components/script/dom/htmlhrelement.rs
@mbrubeck
Copy link
Contributor

mbrubeck commented Apr 12, 2016

@bors-servo r+

Reviewed 7 of 7 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable
@bors-servo
Copy link
Contributor

bors-servo commented Apr 12, 2016

📌 Commit 3ebf43a has been approved by mbrubeck
@frewsxcv
Copy link
Member Author

frewsxcv commented Apr 12, 2016

@bors-servo r=-50
@bors-servo
Copy link
Contributor

bors-servo commented Apr 12, 2016

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #10527
@bors-servo
Copy link
Contributor

bors-servo commented Apr 12, 2016

📌 Commit 3ebf43a has been approved by -50
@frewsxcv
Copy link
Member Author

frewsxcv commented Apr 12, 2016

@bors-servo r=mbrubeck p=-50

Sorry for the noise
@bors-servo
Copy link
Contributor

bors-servo commented Apr 12, 2016

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #10527
@bors-servo
Copy link
Contributor

bors-servo commented Apr 12, 2016

📌 Commit 3ebf43a has been approved by mbrubeck
@bors-servo
Copy link
Contributor

bors-servo commented Apr 12, 2016

⌛ Testing commit 3ebf43a with merge f960802...
bors-servo added a commit that referenced this pull request Apr 12, 2016
@bors-servo
Auto merge of #10535 - frewsxcv:hr-align, r=mbrubeck
Loading status checks…
f960802 
Implement 'align' IDL attribute on '<hr>'.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10535)
<!-- Reviewable:end -->
@bors-servo bors-servo mentioned this pull request Apr 12, 2016
Merged
@bors-servo
Copy link
Contributor

bors-servo commented Apr 12, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 3ebf43a into servo:master Apr 12, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@frewsxcv frewsxcv deleted the frewsxcv:hr-align branch Oct 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@frewsxcv @highfive @mbrubeck @bors-servo
You can’t perform that action at this time.