Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PerformanceTiming Interface #10538

Merged
merged 1 commit into from Apr 12, 2016
Merged

Improve PerformanceTiming Interface #10538

merged 1 commit into from Apr 12, 2016
+43 −20

Conversation

@izgzhen
Copy link
Contributor

izgzhen commented Apr 12, 2016

Solving #10428

  • Fix timing precision in old update_with_current_time
  • Correct time unit in navigation_start
  • Add LoadEventStart and LoadEventEnd timing properties

There are still many properties left unimplemented. I tend to leave the for future PRs.

Welcome comments!

This change is Reviewable
@highfive
Copy link

highfive commented Apr 12, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.
@highfive
Copy link

highfive commented Apr 12, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/webidls/PerformanceTiming.webidl, components/script/dom/document.rs, components/script/dom/window.rs, components/script/dom/performancetiming.rs
@highfive
Copy link

highfive commented Apr 12, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
components/script/dom/document.rs Outdated
@@ -2744,8 +2757,13 @@ impl DocumentProgressHandler {
EventCancelable::NotCancelable);
let wintarget = window.upcast::<EventTarget>();
event.set_trusted(true);

update_with_current_time_ms(&document.load_event_start);

This comment has been minimized.

Sign in to view
@Manishearth

Manishearth Apr 12, 2016

Member

spec links please

This comment has been minimized.

Sign in to view
@izgzhen

izgzhen Apr 12, 2016

Author Contributor

Added now, thanks.
@Manishearth
Copy link
Member

Manishearth commented Apr 12, 2016

overall lgtm
@izgzhen izgzhen force-pushed the izgzhen:performance_timing branch from 1658dc9 to 63ee77d Apr 12, 2016
@Manishearth
Copy link
Member

Manishearth commented Apr 12, 2016

r? @KiChjang
@highfive highfive assigned KiChjang and unassigned nox Apr 12, 2016
@KiChjang
Copy link
Member

KiChjang commented Apr 12, 2016

-S-awaiting-review +S-needs-code-changes

This looks pretty decent! r=me modulo my small nit.

Reviewed 3 of 4 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

components/script/dom/document.rs, line 213 [r2] (raw file):
nit: space after ///, and link doesn't work. Did you mean http://w3c.github.io/navigation-timing/#sec-PerformanceNavigationTiming instead?

Comments from Reviewable
@izgzhen izgzhen force-pushed the izgzhen:performance_timing branch from 63ee77d to e22d0e0 Apr 12, 2016
@izgzhen
Copy link
Contributor Author

izgzhen commented Apr 12, 2016

Review status: all files reviewed at latest revision, 2 unresolved discussions.

components/script/dom/document.rs, line 213 [r2] (raw file):
You are right. Thanks for your patience!

Comments from Reviewable
@KiChjang
Copy link
Member

KiChjang commented Apr 12, 2016

@bors-servo r+

Thanks!

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable
@bors-servo
Copy link
Contributor

bors-servo commented Apr 12, 2016

📌 Commit e22d0e0 has been approved by KiChjang
@bors-servo
Copy link
Contributor

bors-servo commented Apr 12, 2016

⌛ Testing commit e22d0e0 with merge 04e2f35...
bors-servo added a commit that referenced this pull request Apr 12, 2016
@bors-servo
Auto merge of #10538 - izgzhen:performance_timing, r=KiChjang
Loading status checks…
04e2f35 
Improve PerformanceTiming Interface

Solving #10428

- Fix timing precision in old `update_with_current_time`
- Correct time unit in `navigation_start`
- Add `LoadEventStart` and `LoadEventEnd` timing properties

There are still many properties left unimplemented. I tend to leave the for future PRs.

Welcome comments!

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10538)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 12, 2016

💔 Test failed - mac-rel-wpt
@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 12, 2016

I'm happy to see:


  ▶ Unexpected subtest result in /hr-time/test_cross_frame_start.html:
  └ PASS [expected FAIL] Child created at least 1 second after parent

  ▶ Unexpected subtest result in /hr-time/test_cross_frame_start.html:
  └ PASS [expected FAIL] Child and parent time bases are correct

Please update the expectation files. (Ask on IRC if you don't know how.)
@izgzhen
fix performance timing precision and navigation_start unit; add LoadE…
Loading status checks…
7169a08 
…ventStart and LoadEventEnd timing
@izgzhen izgzhen force-pushed the izgzhen:performance_timing branch from e22d0e0 to 7169a08 Apr 12, 2016
@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 12, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 12, 2016

📌 Commit 7169a08 has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Apr 12, 2016

⌛ Testing commit 7169a08 with merge fd1e591...
bors-servo added a commit that referenced this pull request Apr 12, 2016
@bors-servo
Auto merge of #10538 - izgzhen:performance_timing, r=Ms2ger
Loading status checks…
fd1e591 
Improve PerformanceTiming Interface

Solving #10428

- Fix timing precision in old `update_with_current_time`
- Correct time unit in `navigation_start`
- Add `LoadEventStart` and `LoadEventEnd` timing properties

There are still many properties left unimplemented. I tend to leave the for future PRs.

Welcome comments!

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10538)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 12, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Apr 12, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 12, 2016

⌛ Testing commit 7169a08 with merge 421dcc9...
bors-servo added a commit that referenced this pull request Apr 12, 2016
@bors-servo
Auto merge of #10538 - izgzhen:performance_timing, r=Ms2ger
Loading status checks…
421dcc9 
Improve PerformanceTiming Interface

Solving #10428

- Fix timing precision in old `update_with_current_time`
- Correct time unit in `navigation_start`
- Add `LoadEventStart` and `LoadEventEnd` timing properties

There are still many properties left unimplemented. I tend to leave the for future PRs.

Welcome comments!

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10538)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 12, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 7169a08 into servo:master Apr 12, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Apr 12, 2016
Merged
@timvandermeij timvandermeij mentioned this pull request Apr 13, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KiChjang KiChjang

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@izgzhen @highfive @Manishearth @KiChjang @bors-servo @Ms2ger @nox
You can’t perform that action at this time.