Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPropogate transformed clipping regions to nested flows. #10579
Merged
Conversation
components/layout/block.rs
Outdated
| @@ -1965,7 +1965,48 @@ impl Flow for BlockFlow { | |||
|
|
|||
| flow::mut_base(kid).late_absolute_position_info = | |||
| late_absolute_position_info_for_children; | |||
| flow::mut_base(kid).clip = clip.clone(); | |||
| let clip = if kid.class() == FlowClass::Block { | |||
This comment has been minimized.
This comment has been minimized.
pcwalton
Apr 13, 2016
Contributor
Why not use flow.is_block_like()? That'll catch tables and stuff too.
This comment has been minimized.
This comment has been minimized.
| }; | ||
| } | ||
| } | ||
| let tmp; |
This comment has been minimized.
This comment has been minimized.
pcwalton
Apr 13, 2016
Contributor
I think I'd prefer a different variable name. clipping_region or something?
|
Fixed both complaints. |
|
@bors-servo: r+ Thanks! |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 13, 2016
Propogate transformed clipping regions to nested flows. Fixes #10559 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10579) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
notriddle commentedApr 13, 2016
Fixes #10559
This change is