New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid moves of Gecko style structs #10582
Conversation
r? @Manishearth |
r=me once the rustup lands |
@Manishearth why does this depend on the rustup? Given that the warnings are non-fatal and local to geckolib, I think it's fine to just land this. |
Because it will warn on the arc right now. r=me then |
@bors-servo r=Manishearth |
📌 Commit d69a678 has been approved by |
⌛ Testing commit d69a678 with merge a1bff7c... |
Avoid moves of Gecko style structs <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10582) <!-- Reviewable:end -->
💔 Test failed - mac-dev-unit |
d69a678
to
8153a46
Compare
The "no gecko style struct" case never gets hit in my local tree anymore because I've matched them all up, but on master it still doesn't, which caused compile bustage. Fixed. @bors-servo r=Manishearth |
📌 Commit 8153a46 has been approved by |
Avoid moves of Gecko style structs <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10582) <!-- Reviewable:end -->
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt |
This change is