Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle th tag as HTMLTableCellElement. #1060 #1061

Merged
merged 1 commit into from Oct 15, 2013

Conversation

@saneyuki
Copy link
Member

commented Oct 15, 2013

No description provided.

@larsbergstrom

This comment has been minimized.

Copy link
Contributor

commented Oct 15, 2013

This looks correct, per http://www.w3.org/TR/CSS2/tables.html, section 17.2.

@larsbergstrom

This comment has been minimized.

Copy link

commented on 31b8737 Oct 15, 2013

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented on 31b8737 Oct 15, 2013

saw approval from larsbergstrom
at saneyuki@31b8737

This comment has been minimized.

Copy link
Contributor

replied Oct 15, 2013

merging saneyuki/servo/th = 31b8737 into auto

This comment has been minimized.

Copy link
Contributor

replied Oct 15, 2013

saneyuki/servo/th = 31b8737 merged ok, testing candidate = 74d84ba

This comment has been minimized.

Copy link
Contributor

replied Oct 15, 2013

fast-forwarding master to auto = 74d84ba

@bors-servo bors-servo merged commit 31b8737 into servo:master Oct 15, 2013
1 check passed
1 check passed
default all tests passed
@Ms2ger

This comment has been minimized.

Copy link
Contributor

commented Oct 15, 2013

This looks correct, per http://www.w3.org/TR/CSS2/tables.html, section 17.2.

Uh, what's that got to do with anything?

@jgraham

This comment has been minimized.

Copy link
Contributor

commented Oct 15, 2013

This is wrong. The HTML spec (not CSS) is the correct reference for the interfaces implemented by various tags and in this case it should be HTMLTableHeaderCellElement [1]

[1] http://www.whatwg.org/specs/web-apps/current-work/multipage/tabular-data.html#the-th-element

@jgraham

This comment has been minimized.

Copy link
Contributor

commented Oct 15, 2013

(fwiw Ms2ger pointed out that other browsers don't implement the extra stuff on <th> compared to <td>. Nevertheless I feel we ought to try this in servo and see if it's web compatible or, if we think that is too big a risk, get the spec changed because then no one else with more to lose will take the risk either)

@saneyuki

This comment has been minimized.

Copy link
Member Author

commented Oct 15, 2013

I'm sorry. It's my careless miss.

OK. I'll create the backout commit and implement their interfaces.

@larsbergstrom

This comment has been minimized.

Copy link
Contributor

commented Oct 15, 2013

No, my fault for using the wrong resource.

@saneyuki

This comment has been minimized.

Copy link
Member Author

commented Oct 15, 2013

Oh, I worked them at #1063:

  • I didn't backout this pullrequest.
  • I added webidl files of HTMLTableDataCellElement & HTMLTableHeaderCellElement.
@saneyuki saneyuki referenced this pull request Oct 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.