Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImproved readability of ensure_bootstrapped #10620
Merged
Conversation
highfive
commented
Apr 14, 2016
|
Heads up! This PR modifies the following files:
|
|
Where did the |
autrilla
force-pushed the
autrilla:mach-command-improvements
branch
from
6dfb386
to
8005808
|
@Ms2ger I must have removed that by accident. It's back now. |
python/servo/command_base.py
Outdated
| if not self.config["tools"]["system-cargo"] and \ | ||
| not path.exists(path.join( | ||
| self.config["tools"]["cargo-root"], "cargo", "bin", "cargo" + BIN_SUFFIX)): | ||
| if not self.config["tools"]["system-cargo"] and not rustc_binary_exists: |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
autrilla
force-pushed the
autrilla:mach-command-improvements
branch
from
8005808
to
ec58332
|
Thanks! :) @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 17, 2016
…eanut Improved readability of ensure_bootstrapped <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10620) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Apr 17, 2016
…eanut Improved readability of ensure_bootstrapped <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10620) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
autrilla commentedApr 14, 2016
This change is