Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse the document base url when resolving iframe URLs #10626
Merged
Conversation
highfive
commented
Apr 15, 2016
|
Heads up! This PR modifies the following files:
|
| let window = window_from_node(self); | ||
| window.get_url().join(&url).ok() | ||
| let document = document_from_node(self); | ||
| document.base_url().join(&url).ok() |
This comment has been minimized.
This comment has been minimized.
KiChjang
Apr 15, 2016
Member
Looks like no other code is referencing document at all, can you make this a one-liner instead?
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r+ Thanks! |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 15, 2016
Use the document base url when resolving iframe URLs Fixes #10576. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10626) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
|
|
Merged
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ziyunli commentedApr 15, 2016
•
edited by KiChjang
Fixes #10576.
This change is