Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten a couple `net` implementations. #10629

Merged
merged 2 commits into from Apr 15, 2016
Merged

Flatten a couple `net` implementations. #10629

merged 2 commits into from Apr 15, 2016

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Apr 15, 2016

Working on some of the TLS related code in net and tried to clean up a couple implementations along the way.

This change is Reviewable
frewsxcv added 2 commits Apr 15, 2016
@frewsxcv
Flatten implementation of `net::file_loader::factory`.
50c6d93
@frewsxcv
Flatten implementation of `net::http_response::HttpResponse`.
Loading status checks…
12dfe6f
@highfive
Copy link

highfive commented Apr 15, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/net/file_loader.rs, components/net/http_loader.rs
@highfive
Copy link

highfive commented Apr 15, 2016

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!
@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 15, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 15, 2016

📌 Commit 12dfe6f has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Apr 15, 2016

⌛ Testing commit 12dfe6f with merge f39ec2b...
bors-servo added a commit that referenced this pull request Apr 15, 2016
@bors-servo
Auto merge of #10629 - frewsxcv:flatten, r=Ms2ger
Loading status checks…
f39ec2b 
Flatten a couple `net` implementations.

Working on some of the TLS related code in `net` and tried to clean up a couple implementations along the way.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10629)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 15, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Apr 15, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 15, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@frewsxcv
Copy link
Member Author

frewsxcv commented Apr 15, 2016

@bors-servo retry #10392
@bors-servo
Copy link
Contributor

bors-servo commented Apr 15, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 15, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 12dfe6f into servo:master Apr 15, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@frewsxcv frewsxcv deleted the frewsxcv:flatten branch Apr 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@frewsxcv @highfive @Ms2ger @bors-servo @KiChjang @jdm
You can’t perform that action at this time.