Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wptrunner. #10631

Merged
merged 3 commits into from Apr 21, 2016
Merged

Update wptrunner. #10631

merged 3 commits into from Apr 21, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 15, 2016 •
edited

Fixes #10540.
Fixes #10392.

This change is Reviewable
@highfive
Copy link

highfive commented Apr 15, 2016

Heads up! This PR modifies the following files:

  • @wafflespeanut: python/servo/devenv_commands.py
  • @jgraham: tests/wpt/harness/wptrunner/executors/pytestrunner/init.py, tests/wpt/harness/wptrunner/wptcommandline.py, tests/wpt/harness/wptrunner/browsers/chrome.py, tests/wpt/harness/wptrunner/environment.py, tests/wpt/harness/wptrunner/wpttest.py, tests/wpt/harness/wptrunner/manifestexpected.py, tests/wpt/harness/wptrunner/executors/pytestrunner/fixtures.py, tests/wpt/harness/wptrunner/executors/executorservo.py, tests/wpt/harness/wptrunner/executors/pytestrunner/runner.py, tests/wpt/harness/README.rst, tests/wpt/harness/docs/expectation.rst, tests/wpt/harness/wptrunner/browsers/firefox.py, tests/wpt/harness/wptrunner/webdriver_server.py, tests/wpt/harness/wptrunner/wptlogging.py, tests/wpt/harness/wptrunner/executors/base.py, tests/wpt/harness/wptrunner/executors/executormarionette.py, tests/wpt/harness/wptrunner/testrunner.py, tests/wpt/harness/wptrunner/executors/executorservodriver.py
@KiChjang
Copy link
Member

KiChjang commented Apr 15, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 15, 2016

📌 Commit 0df270d has been approved by KiChjang
@KiChjang KiChjang assigned KiChjang and unassigned larsbergstrom Apr 15, 2016
@jgraham
Copy link
Contributor

jgraham commented Apr 15, 2016

Reviewed 18 of 19 files at r1.
Review status: 18 of 19 files reviewed at latest revision, 2 unresolved discussions.

python/servo/devenv_commands.py, line 157 [r1] (raw file):
Would be nice to build a funtion that takes a list of commands and runs them in order until one fails. But not necessary now.

python/servo/devenv_commands.py, line 165 [r1] (raw file):
Bleh. It's up to you, but I guess I would be pretty nervous of putting this in the script. Does leaving the .git actually hurt?

Comments from Reviewable
@jgraham
Copy link
Contributor

jgraham commented Apr 15, 2016

Reviewed 1 of 19 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable
@bors-servo
Copy link
Contributor

bors-servo commented Apr 15, 2016

⌛ Testing commit 0df270d with merge 38d21f2...
bors-servo added a commit that referenced this pull request Apr 15, 2016
@bors-servo
Auto merge of #10631 - servo:wptrunner-20160415, r=KiChjang
Loading status checks…
38d21f2 
Update wptrunner.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10631)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 15, 2016

💔 Test failed - mac-rel-wpt
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Apr 16, 2016

@bors-servo retry

  • infra
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2016

⌛ Testing commit 0df270d with merge e6ae289...
bors-servo added a commit that referenced this pull request Apr 16, 2016
@bors-servo
Auto merge of #10631 - servo:wptrunner-20160415, r=KiChjang
Loading status checks…
e6ae289 
Update wptrunner.

Fixes #10540.
Fixes #10392.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10631)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2016

💔 Test failed - mac-dev-unit
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Apr 16, 2016

@bors-servo retry

  • infra
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev are reusable. Rebuilding only linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2016

💔 Test failed - mac-rel-wpt
@jdm
Copy link
Member

jdm commented Apr 16, 2016

This does not need any further retries, in case that's unclear.
@Ms2ger Ms2ger force-pushed the wptrunner-20160415 branch from 0df270d to 110d1bb Apr 18, 2016
bors-servo added a commit that referenced this pull request Apr 20, 2016
@bors-servo
Auto merge of #10631 - servo:wptrunner-20160415, r=KiChjang
Loading status checks…
742b98a 
Update wptrunner.

Fixes #10540.
Fixes #10392.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10631)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2016

💔 Test failed - mac-rel-wpt
@jdm
Copy link
Member

jdm commented Apr 20, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css are reusable. Rebuilding only linux-rel, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2016

💔 Test failed - mac-rel-wpt
@jdm
Copy link
Member

jdm commented Apr 20, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css are reusable. Rebuilding only mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2016

💔 Test failed - mac-rel-wpt
@jdm
Copy link
Member

jdm commented Apr 20, 2016

@bors-servo: retry
@jdm
Copy link
Member

jdm commented Apr 21, 2016

@bors-servo: r-
@jdm
Copy link
Member

jdm commented Apr 21, 2016

#10759 isn't intermittent; it needs to be marked as passing for this PR.
Ms2ger added 2 commits Apr 15, 2016
@Ms2ger
Update wptrunner.
82e2d01
@Ms2ger
Note bugs.
Loading status checks…
5944add
@Ms2ger Ms2ger force-pushed the wptrunner-20160415 branch from 9b07ef8 to 5944add Apr 21, 2016
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Apr 21, 2016

@bors-servo r=KiChjang
@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2016

📌 Commit 5944add has been approved by KiChjang
@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2016

⌛ Testing commit 5944add with merge 9c172f4...
bors-servo added a commit that referenced this pull request Apr 21, 2016
@bors-servo
Auto merge of #10631 - servo:wptrunner-20160415, r=KiChjang
Loading status checks…
9c172f4 
Update wptrunner.

Fixes #10540.
Fixes #10392.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10631)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 5944add into master Apr 21, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@notriddle notriddle deleted the wptrunner-20160415 branch Apr 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KiChjang KiChjang

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
@Ms2ger @highfive @KiChjang @bors-servo @jgraham @larsbergstrom @jdm @edunham
You can’t perform that action at this time.