Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup code regarding mimesniff 'apache bug'. #10640

Merged
merged 3 commits into from Apr 18, 2016
Merged

Cleanup code regarding mimesniff 'apache bug'. #10640

merged 3 commits into from Apr 18, 2016

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Apr 15, 2016

This change is Reviewable
frewsxcv added 3 commits Apr 15, 2016
@frewsxcv
Add relevant sepc link for 'apache bug' mimesniff.
6c0927c
@frewsxcv
Use constructor pattern for `ApacheFlag` enum.
540e5ce
@frewsxcv
Cleanup retrieval of last slice item.
Loading status checks…
da34d46
@highfive
Copy link

highfive commented Apr 15, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/net/resource_thread.rs, components/net/mime_classifier.rs
@highfive
Copy link

highfive commented Apr 15, 2016

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!
components/net/mime_classifier.rs
if last_raw_content_type == b"text/plain"
|| last_raw_content_type == b"text/plain; charset=ISO-8859-1"
|| last_raw_content_type == b"text/plain; charset=iso-8859-1"
|| last_raw_content_type == b"text/plain; charset=UTF-8" {

This comment has been minimized.

Sign in to view
@KiChjang

KiChjang Apr 15, 2016

Member

I'm tempted to use the mime crate for this sort of stuff.

This comment has been minimized.

Sign in to view
@frewsxcv

frewsxcv Apr 15, 2016

Author Member

Maybe, though I'd imagine that should be a separate pull request? I don't know much about any mime crates
@KiChjang
Copy link
Member

KiChjang commented Apr 17, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 17, 2016

📌 Commit da34d46 has been approved by KiChjang
@bors-servo
Copy link
Contributor

bors-servo commented Apr 17, 2016

⌛ Testing commit da34d46 with merge a3a0188...
bors-servo added a commit that referenced this pull request Apr 17, 2016
@bors-servo
Auto merge of #10640 - frewsxcv:apache-flag, r=KiChjang
Loading status checks…
a3a0188 
Cleanup code regarding mimesniff 'apache bug'.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10640)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 17, 2016

💔 Test failed - mac-rel-css
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Apr 17, 2016 

Assertion failed: (HasInsideLoopSuccs && "Loop block has no in-loop successors!"), function verifyLoop, file /Users/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-mac/build/src/llvm/include/llvm/Analysis/LoopInfoImpl.h, line 279.
Build failed, waiting for other jobs to finish...
error: Could not compile `regex`.

To learn more, run the command again with --verbose.
[Warning] Could not generate notification! Optional Python module 'pyobjc' is not installed.
Build completed in 220.61s
@KiChjang KiChjang assigned KiChjang and unassigned asajeffrey Apr 17, 2016
@frewsxcv
Copy link
Member Author

frewsxcv commented Apr 18, 2016

@bors-servo retry

temporary problem?
@bors-servo
Copy link
Contributor

bors-servo commented Apr 18, 2016

⌛ Testing commit da34d46 with merge 40e347d...
bors-servo added a commit that referenced this pull request Apr 18, 2016
@bors-servo
Auto merge of #10640 - frewsxcv:apache-flag, r=KiChjang
Loading status checks…
40e347d 
Cleanup code regarding mimesniff 'apache bug'.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10640)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 18, 2016

💔 Test failed - linux-rel
@frewsxcv
Copy link
Member Author

frewsxcv commented Apr 18, 2016

@bors-servo retry #10549
@bors-servo
Copy link
Contributor

bors-servo commented Apr 18, 2016

⌛ Testing commit da34d46 with merge 6edcad2...
bors-servo added a commit that referenced this pull request Apr 18, 2016
@bors-servo
Auto merge of #10640 - frewsxcv:apache-flag, r=KiChjang
Loading status checks…
6edcad2 
Cleanup code regarding mimesniff 'apache bug'.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10640)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 18, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit da34d46 into servo:master Apr 18, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@frewsxcv frewsxcv deleted the frewsxcv:apache-flag branch Oct 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KiChjang KiChjang

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@frewsxcv @highfive @KiChjang @bors-servo @larsbergstrom @asajeffrey
You can’t perform that action at this time.