Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse os.path.basename instead of split('/')[-1] #10664
Merged
Conversation
highfive
commented
Apr 17, 2016
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @KiChjang (or someone else) soon. |
highfive
commented
Apr 17, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Apr 17, 2016
|
|
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 17, 2016
Use os.path.basename instead of split('/')[-1]
Fixes #10596. I have split up this commit from #10618 as it seem the easiest to review.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10664)
<!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
zwn commentedApr 17, 2016
Fixes #10596. I have split up this commit from #10618 as it seem the easiest to review.
This change is