Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to network preferences, HTTP redirection limiting. #10672

Merged
merged 4 commits into from Apr 18, 2016
Merged

Improvements to network preferences, HTTP redirection limiting. #10672

merged 4 commits into from Apr 18, 2016

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Apr 17, 2016

This change is Reviewable
frewsxcv added 2 commits Apr 17, 2016
@frewsxcv
Rename `net.mime.sniff` pref to `network.mime.sniff`.
07209c7 
Gecko uses the `network` prefix for network related items. Might be good
to mirror that here.
@frewsxcv
Add pref for HTTP redirection limit.
8e14cbc 
The pref key name matches the associated Gecko pref key name.
@highfive
Copy link

highfive commented Apr 17, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/net/resource_thread.rs, components/net/http_loader.rs
frewsxcv added 2 commits Apr 17, 2016
@frewsxcv
Verify number of redirects when we reach limit.
da0adeb
@frewsxcv
Use same value for `network.http.redirection-limit` pref as Gecko.
Loading status checks…
8883ffc
@frewsxcv frewsxcv force-pushed the frewsxcv:net-network branch from 13af980 to 8883ffc Apr 18, 2016
@KiChjang
Copy link
Member

KiChjang commented Apr 18, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 18, 2016

📌 Commit 8883ffc has been approved by KiChjang
@bors-servo
Copy link
Contributor

bors-servo commented Apr 18, 2016

⌛ Testing commit 8883ffc with merge 80662f1...
bors-servo added a commit that referenced this pull request Apr 18, 2016
@bors-servo
Auto merge of #10672 - frewsxcv:net-network, r=KiChjang
Loading status checks…
80662f1 
Improvements to network preferences, HTTP redirection limiting.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10672)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 18, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo mentioned this pull request Apr 18, 2016
Merged
@bors-servo bors-servo merged commit 8883ffc into servo:master Apr 18, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@frewsxcv frewsxcv deleted the frewsxcv:net-network branch Oct 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KiChjang KiChjang

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@frewsxcv @highfive @KiChjang @bors-servo
You can’t perform that action at this time.