Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary `net_traits::LoadData` clone. #10695

Merged
merged 1 commit into from Apr 19, 2016
Merged

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Apr 19, 2016

This change is Reviewable

@highfive
Copy link

highfive commented Apr 19, 2016

Heads up! This PR modifies the following files:

@highfive
Copy link

highfive commented Apr 19, 2016

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!
@frewsxcv frewsxcv force-pushed the frewsxcv:no-clone branch from df935c8 to 7500307 Apr 19, 2016
@KiChjang KiChjang assigned KiChjang and unassigned wafflespeanut Apr 19, 2016
@KiChjang
Copy link
Member

KiChjang commented Apr 19, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Apr 19, 2016

📌 Commit 7500307 has been approved by KiChjang

@bors-servo
Copy link
Contributor

bors-servo commented Apr 19, 2016

Testing commit 7500307 with merge 8415607...

bors-servo added a commit that referenced this pull request Apr 19, 2016
Avoid unnecessary `net_traits::LoadData` clone.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10695)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 19, 2016

💔 Test failed - mac-rel-wpt

@wafflespeanut
Copy link
Member

wafflespeanut commented Apr 19, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Apr 19, 2016

Testing commit 7500307 with merge 407c43f...

bors-servo added a commit that referenced this pull request Apr 19, 2016
Avoid unnecessary `net_traits::LoadData` clone.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10695)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 19, 2016

@bors-servo bors-servo merged commit 7500307 into servo:master Apr 19, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.