Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIntroduce ports/servo for the servo binary. #10707
Closed
+86
−72
Conversation
highfive
commented
Apr 19, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Apr 19, 2016
|
|
|
Yay! I've wanted to do this for a while. Thanks! |
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 19, 2016
Introduce ports/servo for the servo binary. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10707) <!-- Reviewable:end -->
|
|
|
|
|
@larsbergstrom you know what's up with the arm64 failure? |
|
I believe that this means that we're using the system linker |
|
@bors-servo retry
|
|
Needs a rebase before it can be retried. |
highfive
commented
May 4, 2016
|
New code was committed to pull request. |
|
@bors-servo r- try retry |
bors-servo
added a commit
that referenced
this pull request
May 4, 2016
Introduce ports/servo for the servo binary. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10707) <!-- Reviewable:end -->
|
|
|
|
|
|
What's the plan here? I don't believe anybody trying to fix the linker error. |
|
I rebased it for @larsbergstrom to look at the error; I'm happy to rebase again, but preferably only once more |
|
Let's hold off on this one until we move to Cargo workspaces. It just landed in Cargo nightly a couple of builds ago, and I'd like to see us consolidate our toplevel Cargo.toml/Cargo.lock before we move things around again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ms2ger commentedApr 19, 2016
This change is