Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some compile warnings. #10708

Merged
merged 1 commit into from Apr 19, 2016
Merged

Fix some compile warnings. #10708

merged 1 commit into from Apr 19, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 19, 2016

This change is Reviewable
@Ms2ger
Fix some compile warnings.
Loading status checks…
5645a59
@highfive
Copy link

highfive commented Apr 19, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/htmliframeelement.rs, components/script/dom/htmllinkelement.rs
@highfive
Copy link

highfive commented Apr 19, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member

emilio commented Apr 19, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 19, 2016

📌 Commit 5645a59 has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Apr 19, 2016

⌛ Testing commit 5645a59 with merge 4d5fa96...
bors-servo added a commit that referenced this pull request Apr 19, 2016
@bors-servo
Auto merge of #10708 - Ms2ger:warnings, r=emilio
Loading status checks…
4d5fa96 
Fix some compile warnings.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10708)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 19, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
This was referenced Apr 19, 2016
Merged
Closed
@bors-servo bors-servo merged commit 5645a59 into servo:master Apr 19, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the Ms2ger:warnings branch May 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @emilio @bors-servo @SimonSapin
You can’t perform that action at this time.