Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout: Implement support for `overflow: scroll` in WebRender. #10717

Merged
merged 1 commit into from Apr 19, 2016
Merged

layout: Implement support for `overflow: scroll` in WebRender. #10717

merged 1 commit into from Apr 19, 2016
+36 −12

Conversation

@pcwalton
Copy link
Contributor

pcwalton commented Apr 19, 2016

Requires a WebRender upgrade.

r? @glennw

This change is Reviewable
@highfive
Copy link

highfive commented Apr 19, 2016

warning Warning warning

  • These commits modify layout code, but no tests are modified. Please consider adding a test!
@pcwalton
Copy link
Contributor Author

pcwalton commented Apr 19, 2016

Needs servo/webrender#263
@pcwalton
Copy link
Contributor Author

pcwalton commented Apr 19, 2016

This fixes Twitter timelines.
@glennw
Copy link
Member

glennw commented Apr 19, 2016

@pcwalton r=me when cargo.lock is updated to include the WR change. Nice one!
@pcwalton pcwalton force-pushed the pcwalton:wr-overflow-scroll branch from 1bd4bbe to 63279c3 Apr 19, 2016
@pcwalton
Copy link
Contributor Author

pcwalton commented Apr 19, 2016

@bors-servo: r=glennw
@bors-servo
Copy link
Contributor

bors-servo commented Apr 19, 2016

📌 Commit 63279c3 has been approved by glennw
@pcwalton
layout: Implement support for `overflow: scroll` in WebRender.
Loading status checks…
63279c3 
Includes a WebRender upgrade.

Improves Twitter.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 19, 2016

⌛ Testing commit 63279c3 with merge 64b0daf...
bors-servo added a commit that referenced this pull request Apr 19, 2016
@bors-servo
Auto merge of #10717 - pcwalton:wr-overflow-scroll, r=glennw
Loading status checks…
64b0daf 
layout: Implement support for `overflow: scroll` in WebRender.

Requires a WebRender upgrade.

r? @glennw

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10717)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 19, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 63279c3 into servo:master Apr 19, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Apr 19, 2016
Closed
@paulrouget
Copy link
Contributor

paulrouget commented May 3, 2016

Is that supposed to fix #10434 ?
@pcwalton pcwalton mentioned this pull request May 3, 2016
Closed
@pcwalton pcwalton mentioned this pull request May 17, 2016
Closed
@paulrouget paulrouget mentioned this pull request May 18, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@glennw glennw

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@pcwalton @highfive @glennw @bors-servo @paulrouget
You can’t perform that action at this time.