Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some Emacs & Vim modelines #10723

Merged
merged 1 commit into from Apr 22, 2016
Merged

Remove some Emacs & Vim modelines #10723

merged 1 commit into from Apr 22, 2016

Conversation

@edunham
Copy link
Contributor

edunham commented Apr 19, 2016

This might be a bad idea, especially on the webidl side. However, we started talking about the idea that modelines are a lint error (#10719), and these changes would be required before enabling a modeline lint.

If it bitrots, it's easy to recreate with

find * -type f -exec sed '/- Mode:/d' -i {} +
find * -type f -exec sed '/ vim:/d' -i {} +
git checkout -- python/tidy/servo_tidy/tidy.py
git checkout -- python/tidy/servo_tidy_tests/spec.webidl
git commit -a

This change is Reviewable

@highfive
Copy link

highfive commented Apr 19, 2016

Heads up! This PR modifies the following files:

@highfive
Copy link

highfive commented Apr 19, 2016

warning Warning warning

  • This pull request modifies the contents of
    'tests/wpt/css-tests/', which are overwriten occasionally whenever the
    directory is synced from upstream.
@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 20, 2016

Definitely r- on the changes to tests/wpt.

@edunham edunham force-pushed the edunham:modelines branch from 12a2e1c to 7ae63b1 Apr 20, 2016
@edunham edunham changed the title Remove all Emacs & Vim modelines Remove ~all~ Emacs & Vim modelines Apr 20, 2016
@edunham edunham changed the title Remove ~all~ Emacs & Vim modelines Remove some Emacs & Vim modelines Apr 20, 2016
@wafflespeanut
Copy link
Member

wafflespeanut commented Apr 21, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2016

📌 Commit 7ae63b1 has been approved by Wafflespeanut

@bors-servo
Copy link
Contributor

bors-servo commented Apr 22, 2016

Testing commit 7ae63b1 with merge dff217c...

bors-servo added a commit that referenced this pull request Apr 22, 2016
Remove some Emacs & Vim modelines

This might be a bad idea, especially on the webidl side. However, we started talking about the idea that modelines are a lint error (#10719), and these changes would be required before enabling a modeline lint.

If it bitrots, it's easy to recreate with
```
find * -type f -exec sed '/- Mode:/d' -i {} +
find * -type f -exec sed '/ vim:/d' -i {} +
git checkout -- python/tidy/servo_tidy/tidy.py
git checkout -- python/tidy/servo_tidy_tests/spec.webidl
git commit -a
```

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10723)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 22, 2016

@bors-servo bors-servo merged commit 7ae63b1 into servo:master Apr 22, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.