Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove some Emacs & Vim modelines #10723
Merged
Conversation
highfive
commented
Apr 19, 2016
•
|
Heads up! This PR modifies the following files:
|
highfive
commented
Apr 19, 2016
|
Definitely r- on the changes to |
This was referenced Apr 20, 2016
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 22, 2016
Remove some Emacs & Vim modelines This might be a bad idea, especially on the webidl side. However, we started talking about the idea that modelines are a lint error (#10719), and these changes would be required before enabling a modeline lint. If it bitrots, it's easy to recreate with ``` find * -type f -exec sed '/- Mode:/d' -i {} + find * -type f -exec sed '/ vim:/d' -i {} + git checkout -- python/tidy/servo_tidy/tidy.py git checkout -- python/tidy/servo_tidy_tests/spec.webidl git commit -a ``` <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10723) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
edunham commentedApr 19, 2016
This might be a bad idea, especially on the webidl side. However, we started talking about the idea that modelines are a lint error (#10719), and these changes would be required before enabling a modeline lint.
If it bitrots, it's easy to recreate with
This change is