Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd unit tests skeleton for the time profiler #10729
Merged
Conversation
This commit adds a test crate for the time profiler to `tests/unit/profile`. The only unit test contained in this crate is a smoke test that the time profiler thread can be created and destroyed. It serves as a place for adding new tests in the future.
|
@bors-servo r+ cc @rzambre for need to rebase his branch over this to test the exit-with-confirmation stuff and small changes to starting up the time profiler thread |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 22, 2016
…rgstrom Add unit tests skeleton for the time profiler This commit adds a test crate for the time profiler to `tests/unit/profile`. The only unit test contained in this crate is a smoke test that the time profiler thread can be created and destroyed. It serves as a place for adding new tests in the future. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10729) <!-- Reviewable:end -->
|
|
|
@bors-servo retry #10760 |
bors-servo
added a commit
that referenced
this pull request
Apr 22, 2016
…rgstrom Add unit tests skeleton for the time profiler This commit adds a test crate for the time profiler to `tests/unit/profile`. The only unit test contained in this crate is a smoke test that the time profiler thread can be created and destroyed. It serves as a place for adding new tests in the future. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10729) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fitzgen commentedApr 19, 2016
This commit adds a test crate for the time profiler to
tests/unit/profile. Theonly unit test contained in this crate is a smoke test that the time profiler
thread can be created and destroyed. It serves as a place for adding new tests
in the future.
This change is