Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SpiderMonkey #10756

Merged
merged 1 commit into from May 3, 2016
Merged

Update SpiderMonkey #10756

merged 1 commit into from May 3, 2016

Conversation

@nox
Copy link
Member

nox commented Apr 20, 2016

This change is Reviewable

@highfive
Copy link

highfive commented Apr 20, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/textencoder.rs, components/script/dom/bindings/utils.rs, components/script/dom/window.rs, components/script/dom/bindings/refcounted.rs, components/script/dom/browsingcontext.rs, components/script/dom/imagedata.rs, components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/bindings/interface.rs, components/script/Cargo.toml, components/script/dom/bindings/proxyhandler.rs, components/script/script_thread.rs, components/script/script_runtime.rs, components/script/dom/bindings/conversions.rs, components/script/dom/bindings/codegen/Bindings.conf, components/script/dom/bindings/trace.rs, components/script/dom/websocket.rs, components/script/dom/bindings/structuredclone.rs
@highfive
Copy link

highfive commented Apr 20, 2016

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@nox nox assigned Ms2ger and unassigned KiChjang Apr 20, 2016
@nox
Copy link
Member Author

nox commented Apr 20, 2016

1 similar comment
@nox
Copy link
Member Author

nox commented Apr 20, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2016

Trying commit 70556b6 with merge 9fa8bd8...

bors-servo added a commit that referenced this pull request Apr 20, 2016
💩 Do not merge yet, just trying 💩 SpiderMonkey update

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10756)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2016

💔 Test failed - linux-rel

@nox
Copy link
Member Author

nox commented Apr 20, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2016

Trying commit f3b3759 with merge 07706e0...

bors-servo added a commit that referenced this pull request Apr 20, 2016
💩 Do not merge yet, just trying 💩 SpiderMonkey update

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10756)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2016

💔 Test failed - mac-rel-wpt

@nox
Copy link
Member Author

nox commented Apr 20, 2016

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2016

Trying commit f3b3759 with merge 260d13d...

bors-servo added a commit that referenced this pull request Apr 20, 2016
💩 Do not merge yet, just trying 💩 SpiderMonkey update

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10756)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2016

💔 Test failed - android

@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2016

The latest upstream changes (presumably #10777) made this pull request unmergeable. Please resolve the merge conflicts.

@highfive
Copy link

highfive commented May 3, 2016

  ▶ TIMEOUT [expected OK] /html/rendering/replaced-elements/svg-embedded-sizing/svg-in-iframe-fixed.html
  │ 
  └ Xlib:  extension &#34;XFree86-VidModeExtension&#34; missing on display &#34;:0&#34;.

  ▶ Unexpected subtest result in /html/rendering/replaced-elements/svg-embedded-sizing/svg-in-iframe-fixed.html:
  │ TIMEOUT [expected PASS] placeholder: &#39;iframe&#39;, containerWidthStyle: &#39;400px&#39;, placeholderWidthAttr: &#39;100&#39;, placeholderHeightAttr: &#39;100px&#39;, svgViewBoxAttr: &#39;0 0 100 200&#39;, svgWidthAtt</span><span class="stdout">r: &#39;25%&#39;, svgHeightAttr: &#39;25%&#39;, 
  └   → Test timed out

  ▶ TIMEOUT [expected OK] /html/rendering/replaced-elements/svg-embedded-sizing/svg-in-iframe-auto.html
  │ 
  └ Xlib:  extension &#34;XFree86-VidModeExtension&#34; missing on display &#34;:0&#34;.

  ▶ Unexpected subtest result in /html/rendering/replaced-elements/svg-embedded-sizing/svg-in-iframe-auto.html:
  │ TIMEOUT [expected PASS] placeholder: &#39;iframe&#39;, containerHeightStyle: &#39;400px&#39;, placeholderWidthAttr: &#39;50%&#39;, svgViewBoxAttr: &#39;0 0 100 200&#39;, svgWidthAttr: &#39;25%&#39;, svgHeightAttr: &#39;25%&#39;, 
  └   → Test timed out

  ▶ TIMEOUT [expected OK] /html/rendering/replaced-elements/svg-embedded-sizing/svg-in-iframe-percentage.html
  │ 
  └ Xlib:  extension &#34;XFree86-VidModeExtension&#34; missing on display &#34;:0&#34;.

  ▶ Unexpected subtest result in /html/rendering/replaced-elements/svg-embedded-sizing/svg-in-iframe-percentage.html:
  │ TIMEOUT [expected PASS] placeholder: &#39;iframe&#39;, containerWidthStyle: &#39;400px&#39;, placeholderWidthAttr: &#39;50%&#39;, placeholderHeightAttr: &#39;100%&#39;, svgWidthAttr: &#39;25%&#39;, svgHeightAttr: &#39;25%&#39;, 
  └   → Test timed out
@nox
Copy link
Member Author

nox commented May 3, 2016

@bors-servo r=Ms2ger #10457

@bors-servo
Copy link
Contributor

bors-servo commented May 3, 2016

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented May 3, 2016

📌 Commit eb94f1a has been approved by Ms2ger

@highfive highfive assigned nox and unassigned Ms2ger May 3, 2016
@nox
Copy link
Member Author

nox commented May 3, 2016

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented May 3, 2016

Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows are reusable. Rebuilding only linux-rel...

@nox nox assigned Ms2ger and unassigned nox May 3, 2016
@bors-servo
Copy link
Contributor

bors-servo commented May 3, 2016

💔 Test failed - linux-rel

@highfive
Copy link

highfive commented May 3, 2016

  ▶ FAIL [expected PASS] /_mozilla/css/iframe/mozbrowser_navigation.html
  └   → /_mozilla/css/iframe/mozbrowser_navigation.html e60785ff75153e5d215bd0f65141fbb13cfbc61b
/_mozilla/css/iframe/mozbrowser_navigation_ref.html 8250706e506ad24231cc23be315b9b868387c598
Testing e60785ff75153e5d215bd0f65141fbb13cfbc61b == 8250706e506ad24231cc23be315b9b868387c598
@nox
Copy link
Member Author

nox commented May 3, 2016

@bors-servo
Copy link
Contributor

bors-servo commented May 3, 2016

Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows are reusable. Rebuilding only linux-rel...

@bors-servo
Copy link
Contributor

bors-servo commented May 3, 2016

💔 Test failed - linux-rel

@highfive
Copy link

highfive commented May 3, 2016

  ▶ FAIL [expected PASS] /_mozilla/css/iframe/mozbrowser_navigation.html
  └   → /_mozilla/css/iframe/mozbrowser_navigation.html d9d9e489bc5b4508c01b06c7ff92f19dcc2ece3c
/_mozilla/css/iframe/mozbrowser_navigation_ref.html 8250706e506ad24231cc23be315b9b868387c598
Testing d9d9e489bc5b4508c01b06c7ff92f19dcc2ece3c == 8250706e506ad24231cc23be315b9b868387c598
@jdm
Copy link
Member

jdm commented May 3, 2016

@bors-servo
Copy link
Contributor

bors-servo commented May 3, 2016

Testing commit eb94f1a with merge 2c69278...

bors-servo added a commit that referenced this pull request May 3, 2016
Update SpiderMonkey

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10756)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 3, 2016

@bors-servo bors-servo merged commit eb94f1a into master May 3, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nox nox deleted the smup branch May 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.