Ensure that we aren't missing any errors in the tidy self-test. #10758

jdm · 2016-04-20T17:31:17Z

This change is


        Ensure that we aren't missing any errors in the tidy self-test.

highfive · 2016-04-20T17:32:08Z

Heads up! This PR modifies the following files:

@wafflespeanut: python/tidy/servo_tidy_tests/test_tidy.py

wafflespeanut · 2016-04-21T03:52:54Z

Yep, this should be useful.

@bors-servo r+

bors-servo · 2016-04-21T03:52:55Z

📌 Commit c7d5a2b has been approved by Wafflespeanut

wafflespeanut · 2016-04-21T03:55:29Z

Hmm, I can't find the failed build in appveyor, and I'm also confused why there's no Travis build for this PR.

bors-servo · 2016-04-21T05:54:15Z

⌛ Testing commit c7d5a2b with merge 8e93fd9...


        Auto merge of #10758 - jdm:tidy_check_completeness, r=Wafflespeanut

@wafflespeanut

Ensure that we aren't missing any errors in the tidy self-test. r? @wafflespeanut  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10758)

bors-servo · 2016-04-21T06:40:25Z

💔 Test failed - mac-rel-wpt

wafflespeanut · 2016-04-21T07:02:51Z

@bors-servo retry #10760

bors-servo · 2016-04-21T07:02:53Z

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css are reusable. Rebuilding only mac-rel-wpt...

bors-servo · 2016-04-21T08:24:18Z

💔 Test failed - mac-rel-wpt

wafflespeanut · 2016-04-21T08:30:35Z

@bors-servo retry #10698

wafflespeanut · 2016-04-21T13:33:10Z

@bors-servo retry

wafflespeanut · 2016-04-21T13:45:49Z

~~(I think it's gone haywire)~~ ehm, no...

@bors-servo r+

bors-servo · 2016-04-21T13:45:50Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: #10754

bors-servo · 2016-04-21T13:45:50Z

📌 Commit c7d5a2b has been approved by Wafflespeanut

bors-servo · 2016-04-21T13:46:26Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: #10754

bors-servo · 2016-04-21T13:46:26Z

📌 Commit c7d5a2b has been approved by Wafflespeanut


        Auto merge of #10758 - jdm:tidy_check_completeness, r=Wafflespeanut

@wafflespeanut

Ensure that we aren't missing any errors in the tidy self-test. r? @wafflespeanut  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10758)

bors-servo · 2016-04-21T14:31:03Z

⌛ Testing commit c7d5a2b with merge b90fa6e...

bors-servo · 2016-04-21T17:41:59Z

💔 Test failed - mac-rel-wpt

wafflespeanut · 2016-04-21T17:44:20Z

@bors-servo retry #10698

wafflespeanut · 2016-04-22T05:44:47Z

@bors-servo retry

bors-servo · 2016-04-22T06:08:38Z

⌛ Testing commit c7d5a2b with merge 996207a...


        Auto merge of #10758 - jdm:tidy_check_completeness, r=Wafflespeanut

@wafflespeanut

Ensure that we aren't missing any errors in the tidy self-test. r? @wafflespeanut  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10758)

bors-servo · 2016-04-22T06:54:17Z

💔 Test failed - mac-rel-wpt

wafflespeanut · 2016-04-22T07:03:57Z

@bors-servo retry #10660

bors-servo · 2016-04-22T07:40:32Z

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css are reusable. Rebuilding only mac-rel-wpt...

bors-servo · 2016-04-22T08:26:16Z

💔 Test failed - mac-rel-wpt

wafflespeanut · 2016-04-22T08:29:55Z

@bors-servo retry #10760

bors-servo · 2016-04-22T09:40:30Z

⌛ Testing commit c7d5a2b with merge 6f801e3...


        Auto merge of #10758 - jdm:tidy_check_completeness, r=Wafflespeanut

@wafflespeanut

Ensure that we aren't missing any errors in the tidy self-test. r? @wafflespeanut  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10758)

bors-servo · 2016-04-22T11:15:42Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt

wafflespeanut · 2016-04-22T11:16:39Z

Finally!

Ensure that we aren't missing any errors in the tidy self-test.

Loading status checks…

c7d5a2b

highfive assigned wafflespeanut Apr 20, 2016

highfive added the S-awaiting-review label Apr 20, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels Apr 21, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Apr 21, 2016

bors-servo mentioned this pull request Apr 21, 2016

Implement stencil fns for WebGLRenderingContext #10670

Merged

highfive added the S-tests-failed label Apr 21, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Apr 21, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Apr 21, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Apr 22, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Apr 22, 2016

highfive added the S-tests-failed label Apr 22, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Apr 22, 2016

bors-servo merged commit c7d5a2b into servo:master Apr 22, 2016
1 of 2 checks passed

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Apr 22, 2016

bors-servo mentioned this pull request Apr 22, 2016

Report lines starting with && in tidy #10751

Merged

wafflespeanut mentioned this pull request Apr 22, 2016

Test for tidy.check_lock function #9152 #10775

Merged

servo / servo

Ensure that we aren't missing any errors in the tidy self-test. #10758

Ensure that we aren't missing any errors in the tidy self-test. #10758

jdm commented Apr 20, 2016

highfive commented Apr 20, 2016

wafflespeanut commented Apr 21, 2016

bors-servo commented Apr 21, 2016

wafflespeanut commented Apr 21, 2016

bors-servo commented Apr 21, 2016

bors-servo commented Apr 21, 2016

wafflespeanut commented Apr 21, 2016

bors-servo commented Apr 21, 2016

bors-servo commented Apr 21, 2016

wafflespeanut commented Apr 21, 2016

wafflespeanut commented Apr 21, 2016

wafflespeanut commented Apr 21, 2016 •

edited

bors-servo commented Apr 21, 2016

bors-servo commented Apr 21, 2016

bors-servo commented Apr 21, 2016

bors-servo commented Apr 21, 2016

bors-servo commented Apr 21, 2016

bors-servo commented Apr 21, 2016

wafflespeanut commented Apr 21, 2016

wafflespeanut commented Apr 22, 2016

bors-servo commented Apr 22, 2016

bors-servo commented Apr 22, 2016

wafflespeanut commented Apr 22, 2016

bors-servo commented Apr 22, 2016

bors-servo commented Apr 22, 2016

wafflespeanut commented Apr 22, 2016

bors-servo commented Apr 22, 2016

bors-servo commented Apr 22, 2016

wafflespeanut commented Apr 22, 2016

servo / servo

Join GitHub today

Ensure that we aren't missing any errors in the tidy self-test. #10758

Ensure that we aren't missing any errors in the tidy self-test. #10758

Conversation

jdm commented Apr 20, 2016

highfive commented Apr 20, 2016

wafflespeanut commented Apr 21, 2016

bors-servo commented Apr 21, 2016

wafflespeanut commented Apr 21, 2016

bors-servo commented Apr 21, 2016

bors-servo commented Apr 21, 2016

wafflespeanut commented Apr 21, 2016

bors-servo commented Apr 21, 2016

bors-servo commented Apr 21, 2016

wafflespeanut commented Apr 21, 2016

wafflespeanut commented Apr 21, 2016

wafflespeanut commented Apr 21, 2016 • edited

bors-servo commented Apr 21, 2016

bors-servo commented Apr 21, 2016

bors-servo commented Apr 21, 2016

bors-servo commented Apr 21, 2016

bors-servo commented Apr 21, 2016

bors-servo commented Apr 21, 2016

wafflespeanut commented Apr 21, 2016

wafflespeanut commented Apr 22, 2016

bors-servo commented Apr 22, 2016

bors-servo commented Apr 22, 2016

wafflespeanut commented Apr 22, 2016

bors-servo commented Apr 22, 2016

bors-servo commented Apr 22, 2016

wafflespeanut commented Apr 22, 2016

bors-servo commented Apr 22, 2016

bors-servo commented Apr 22, 2016

wafflespeanut commented Apr 22, 2016

wafflespeanut commented Apr 21, 2016 •

edited