Implements Node::isSameNode

[amarant]

Fixes #10746

I adapted the tests from dom/nodes/Node-isEqualNode.html
should I also add ones for xhtml too like here : dom/nodes/Node-isEqualNode-xhtml.xhtml ?

---

This change is

[highfive]

Heads up! This PR modifies the following files:

• @KiChjang: components/script/dom/node.rs, components/script/dom/webidls/Node.webidl

[Ms2ger]

@bors-servo try

No, this is more than enough. You will need to update some expectations for interfaces.html (as reported by bors; let me know if you need help) and rebase over #10777, but otherwise this is good to go.

[bors-servo]

⌛ Trying commit 21e3765 with merge 8646e6e...

[bors-servo]

💔 Test failed - linux-rel

[Ms2ger]

  ▶ Unexpected subtest result in /dom/interfaces.html:
  └ PASS [expected FAIL] Node interface: operation isSameNode(Node)

  ▶ Unexpected subtest result in /dom/interfaces.html:
  └ PASS [expected FAIL] Node interface: new Document() must inherit property "isSameNode" with the proper type (31)

  ▶ Unexpected subtest result in /dom/interfaces.html:
  └ PASS [expected FAIL] Node interface: calling isSameNode(Node) on new Document() with too few arguments must throw TypeError

  ▶ Unexpected subtest result in /dom/interfaces.html:
  └ PASS [expected FAIL] Node interface: xmlDoc must inherit property "isSameNode" with the proper type (31)

  ▶ Unexpected subtest result in /dom/interfaces.html:
  └ PASS [expected FAIL] Node interface: calling isSameNode(Node) on xmlDoc with too few arguments must throw TypeError

  ▶ Unexpected subtest result in /dom/interfaces.html:
  └ PASS [expected FAIL] Node interface: document.doctype must inherit property "isSameNode" with the proper type (31)

  ▶ Unexpected subtest result in /dom/interfaces.html:
  └ PASS [expected FAIL] Node interface: calling isSameNode(Node) on document.doctype with too few arguments must throw TypeError

  ▶ Unexpected subtest result in /dom/interfaces.html:
  └ PASS [expected FAIL] Node interface: document.createDocumentFragment() must inherit property "isSameNode" with the proper type (31)

  ▶ Unexpected subtest result in /dom/interfaces.html:
  └ PASS [expected FAIL] Node interface: calling isSameNode(Node) on document.createDocumentFragment() with too few arguments must throw TypeError

  ▶ Unexpected subtest result in /dom/interfaces.html:
  └ PASS [expected FAIL] Node interface: element must inherit property "isSameNode" with the proper type (31)

  ▶ Unexpected subtest result in /dom/interfaces.html:
  └ PASS [expected FAIL] Node interface: calling isSameNode(Node) on element with too few arguments must throw TypeError

  ▶ Unexpected subtest result in /dom/interfaces.html:
  └ PASS [expected FAIL] Node interface: document.createTextNode("abc") must inherit property "isSameNode" with the proper type (31)

  ▶ Unexpected subtest result in /dom/interfaces.html:
  └ PASS [expected FAIL] Node interface: calling isSameNode(Node) on document.createTextNode("abc") with too few arguments must throw TypeError

  ▶ Unexpected subtest result in /dom/interfaces.html:
  └ PASS [expected FAIL] Node interface: xmlDoc.createProcessingInstruction("abc", "def") must inherit property "isSameNode" with the proper type (31)

  ▶ Unexpected subtest result in /dom/interfaces.html:
  └ PASS [expected FAIL] Node interface: calling isSameNode(Node) on xmlDoc.createProcessingInstruction("abc", "def") with too few arguments must throw TypeError

  ▶ Unexpected subtest result in /dom/interfaces.html:
  └ PASS [expected FAIL] Node interface: document.createComment("abc") must inherit property "isSameNode" with the proper type (31)

  ▶ Unexpected subtest result in /dom/interfaces.html:
  └ PASS [expected FAIL] Node interface: calling isSameNode(Node) on document.createComment("abc") with too few arguments must throw TypeError

(scroll-to-top.html is an intermittent)

[bors-servo]

☔ The latest upstream changes (presumably #10777) made this pull request unmergeable. Please resolve the merge conflicts.

[amarant]

I don't understand what went wrong ?

[jdm]

All of those PASS [expected FAIL] bits are tests that did not succeed before your changes. The text expectation files need to be updated to reflect the fact that they are now expected to succeed.

[amarant]

This is what I did with my last commit ammend, but the travis error of the new CI build is strange :

Broadcast message from root@testing-gce-d1d1ce5e-48cd-4e0b-875f-29503086cd6b (unknown) at 19:12 ... The system is going down for power off NOW! No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself. The build has been terminated

[jdm]

I restarted it.

[Ms2ger]

Looks good, but needs a rebase.

[bors-servo]

☔ The latest upstream changes (presumably #10802) made this pull request unmergeable. Please resolve the merge conflicts.

[Ms2ger]

@bors-servo r+

Thanks!

[bors-servo]

📌 Commit ed42cc7 has been approved by Ms2ger

[bors-servo]

⌛ Testing commit ed42cc7 with merge 4f05ea7...

[bors-servo]

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt