Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSSRule, CSSRuleList, CSSStyleSheet partial implementation #10765

Closed
wants to merge 32 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
a51248b
CSSRule, CSSRuleList, CSSStyleSheet partial implementation
srm09 Apr 20, 2016
17f919c
addressed majority of review comments
Apr 22, 2016
bb6427b
Resolved review comments with window error persisting
Apr 24, 2016
c4dfe14
review comments
Apr 25, 2016
5d0fadc
Fixed review comments and implementations
srm09 Apr 27, 2016
47dce3a
CSSRule, CSSRuleList, CSSStyleSheet partial implementation
srm09 Apr 20, 2016
5f8a60c
addressed majority of review comments
Apr 22, 2016
e9b0163
Resolved review comments with window error persisting
Apr 24, 2016
eca5bf6
Addressed review comments and implementations
srm09 Apr 27, 2016
378a2f4
Fixed Tidy Tests
Apr 6, 2016
7bb79a1
tried to fix review comments
May 1, 2016
3577d97
Solved cssstylesheet cssrule issue
May 1, 2016
08ddcbb
Added get owner node method
srm09 May 1, 2016
383a8d4
Added length for css rules:
May 1, 2016
1323d80
Solved tidy issues
May 1, 2016
7c88de0
Merge branch 'tmp' of https://github.com/mohammed-alfatih/servo into tmp
May 1, 2016
6557b73
get_nth
May 2, 2016
b9812fd
Called CSSRuleList::new
srm09 May 2, 2016
44ea6ea
Addressed all review comments
May 2, 2016
6f20811
CSSRule, CSSRuleList, CSSStyleSheet partial implementation
srm09 Apr 20, 2016
891f118
addressed majority of review comments
Apr 22, 2016
022593f
Resolved review comments with window error persisting
Apr 24, 2016
da035ae
review comments
Apr 25, 2016
231e66b
Fixed review comments and implementations
srm09 Apr 27, 2016
cad69ca
CSSRule, CSSRuleList, CSSStyleSheet partial implementation
srm09 Apr 20, 2016
cc94b6a
addressed majority of review comments
Apr 22, 2016
bb4a897
Resolved review comments with window error persisting
Apr 24, 2016
ff9a6e7
Fixed Tidy Tests
Apr 6, 2016
1ee1950
tried to fix review comments
May 1, 2016
022946c
Merge branch 'tmp' into sub
srm09 May 2, 2016
6714691
Fixed tidy tests
srm09 May 2, 2016
95fe153
fixed test expectations
May 3, 2016
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Resolved review comments with window error persisting

  • Loading branch information
Isha Bobra authored and srm09 committed May 2, 2016
commit bb4a8971e30f94b7aaddd05c5f36884a941a327b
@@ -96,9 +96,6 @@ use url::Url;
use util::str::{DOMString, LengthOrPercentageOrAuto};
use uuid::Uuid;
use webrender_traits::WebGLError;
use style::selector_impl::ServoSelectorImpl;
use style::stylesheets::CSSRule;


/// A trait to allow tracing (only) DOM objects.
pub trait JSTraceable {
@@ -72,6 +72,7 @@ use dom::nodelist::NodeList;
use dom::processinginstruction::ProcessingInstruction;
use dom::progressevent::ProgressEvent;
use dom::range::Range;
use dom::servohtmlparser::{ParserRoot, ParserRef, MutNullableParserField};
use dom::storageevent::StorageEvent;
use dom::stylesheetlist::StyleSheetList;
use dom::cssstylesheet::CSSStyleSheet;
@@ -239,9 +239,9 @@ pub mod crypto;
pub mod css;
pub mod cssrule;
pub mod cssrulelist;
pub mod cssstyledeclaration;
pub mod cssstylerule;
pub mod cssstylesheet;
pub mod cssstyledeclaration;
pub mod customevent;
pub mod dedicatedworkerglobalscope;
pub mod document;
@@ -65,9 +65,8 @@ impl StyleSheetMethods for StyleSheet {
self.title.clone()
}

// https://drafts.csswg.org/cssom/#dom-stylesheet-ownernode
/*fn GetOwnerNode(&self) -> Option<UnionTypes::ElementOrProcessingInstruction>{
//None
self.owner.unwrap().deref().downcast::<Element>()
}*/
// https://drafts.csswg.org/cssom/#dom-stylesheet-title
fn GetOwnerNode(&self) -> Option<UnionTypes::ElementOrProcessingInstruction>{
None
}
}
@@ -6,7 +6,7 @@
interface StyleSheet {
readonly attribute DOMString type_;
readonly attribute DOMString? href;
// readonly attribute (Element or ProcessingInstruction)? ownerNode;
readonly attribute (Element or ProcessingInstruction)? ownerNode;
// readonly attribute StyleSheet? parentStyleSheet;
readonly attribute DOMString? title;

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.