Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for keyevents in Document::createEvent #10769

Merged
merged 1 commit into from Apr 22, 2016

Conversation

@tetsuharuohzeki
Copy link
Member

tetsuharuohzeki commented Apr 21, 2016

Fix #10735


This change is Reviewable

@highfive
Copy link

highfive commented Apr 21, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/document.rs
@frewsxcv
Copy link
Member

frewsxcv commented Apr 21, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2016

📌 Commit b4cf3b8 has been approved by frewsxcv

@tetsuharuohzeki
Copy link
Member Author

tetsuharuohzeki commented Apr 21, 2016

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2016

Testing commit b4cf3b8 with merge 2f82231...

bors-servo added a commit that referenced this pull request Apr 21, 2016
Drop support for keyevents in Document::createEvent

Fix #10735

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10769)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2016

💔 Test failed - linux-rel

@jdm
Copy link
Member

jdm commented Apr 22, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Apr 22, 2016

Testing commit b4cf3b8 with merge e12fc2a...

bors-servo added a commit that referenced this pull request Apr 22, 2016
Drop support for keyevents in Document::createEvent

Fix #10735

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10769)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 22, 2016

@bors-servo bors-servo merged commit b4cf3b8 into servo:master Apr 22, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@tetsuharuohzeki tetsuharuohzeki deleted the tetsuharuohzeki:keyevents branch Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.