Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not render the contents of block-level replaced elements. #10770

Merged
merged 1 commit into from Apr 23, 2016
Merged

Do not render the contents of block-level replaced elements. #10770

merged 1 commit into from Apr 23, 2016

Conversation

@notriddle
Copy link
Contributor

notriddle commented Apr 21, 2016

Fixes #10733

This change is Reviewable
@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 22, 2016

r? @mbrubeck
@highfive highfive assigned mbrubeck and unassigned KiChjang Apr 22, 2016
@mbrubeck
Copy link
Contributor

mbrubeck commented Apr 22, 2016

@bors-servo r+

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable
@bors-servo
Copy link
Contributor

bors-servo commented Apr 22, 2016

📌 Commit 58276c6 has been approved by mbrubeck
@bors-servo
Copy link
Contributor

bors-servo commented Apr 22, 2016

⌛ Testing commit 58276c6 with merge 986cdd3...
bors-servo added a commit that referenced this pull request Apr 22, 2016
@bors-servo
Auto merge of #10770 - notriddle:canvas_placeholder_block, r=mbrubeck
Loading status checks…
986cdd3 
Do not render the contents of block-level replaced elements.

Fixes #10733

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10770)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 23, 2016

💔 Test failed - mac-rel-wpt
@highfive
Copy link

highfive commented Apr 23, 2016 

  ▶ FAIL [expected PASS] /_mozilla/mozilla/details_ui_closed.html
  └   → /_mozilla/mozilla/details_ui_closed.html a92a9b00627c1d21a35ec1357d5395709e728586
/_mozilla/mozilla/details_ui_closed_</span><span class="stdout">ref.html 46af31209b1f9fcc1b26691e9e18938be1913e72
Testing a92a9b00627c1d21a35ec1357d5395709e728586 == 46af31209b1f9fcc1b26691e9e18938be1913e72

  ▶ FAIL [expected PASS] /_mozilla/mozilla/details_ui_opened.html
  └   → /_mozilla/mozilla/details_ui_opened.html eae9445162b39b1a00193e01c1b71fe68656562d
/_mozilla/mozilla/details_ui_opened_ref.html 68aa055f9836129b425022d1a322bbece63e8f5c
Testing eae9445162b39b1a00193e01c1b71fe68656562d == 68aa055f9836129b425022d1a322bbece63e8f5c
@notriddle
Do not render the contents of block-level replaced elements.
Loading status checks…
5a90c8f 
Fixes #10733
@notriddle
Copy link
Contributor Author

notriddle commented Apr 23, 2016

@bors-servo r=mbrubeck
@bors-servo
Copy link
Contributor

bors-servo commented Apr 23, 2016

🔑 Insufficient privileges
@KiChjang
Copy link
Member

KiChjang commented Apr 23, 2016

@bors-servo r=mbrubeck delegate+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 23, 2016

✌️ @notriddle can now approve this pull request
@bors-servo
Copy link
Contributor

bors-servo commented Apr 23, 2016

📌 Commit 5a90c8f has been approved by mbrubeck
@bors-servo
Copy link
Contributor

bors-servo commented Apr 23, 2016

⌛ Testing commit 5a90c8f with merge 5a5e928...
bors-servo added a commit that referenced this pull request Apr 23, 2016
@bors-servo
Auto merge of #10770 - notriddle:canvas_placeholder_block, r=mbrubeck
Loading status checks…
5a5e928 
Do not render the contents of block-level replaced elements.

Fixes #10733

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10770)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 23, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 5a90c8f into servo:master Apr 23, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@notriddle notriddle deleted the notriddle:canvas_placeholder_block branch Apr 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@notriddle @Ms2ger @mbrubeck @bors-servo @highfive @KiChjang
You can’t perform that action at this time.