Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upupdated Blob constructor to use optional #10795
Merged
Conversation
highfive
commented
Apr 21, 2016
|
Heads up! This PR modifies the following files:
|
components/script/dom/blob.rs
Outdated
| pub fn Constructor_(global: GlobalRef, | ||
| blobParts: Vec<BlobOrString>, | ||
| pub fn Constructor(global: GlobalRef, | ||
| blobParts: Option<Vec<BlobOrString>>, |
This comment has been minimized.
This comment has been minimized.
components/script/dom/blob.rs
Outdated
| .collect(); | ||
| let bytes: Vec<u8> = match blobParts { | ||
| None => Vec::new(), | ||
| Some(blobs) => blobs.iter().flat_map(|bPart| { |
This comment has been minimized.
This comment has been minimized.
|
Thanks! @bors-servo r+ |
|
|
|
|
|
|
|
@bors-servo: retry
|
bors-servo
added a commit
that referenced
this pull request
Apr 23, 2016
updated Blob constructor to use optional fixes #10779 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10795) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
yoava333 commentedApr 21, 2016
fixes #10779
This change is