Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement webglcontextevent #10805

Merged
merged 1 commit into from Apr 25, 2016
Merged

Conversation

@tylersouthwick
Copy link
Contributor

tylersouthwick commented Apr 22, 2016

fixes #10742


This change is Reviewable

@highfive
Copy link

highfive commented Apr 22, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @larsbergstrom (or someone else) soon.

@highfive
Copy link

highfive commented Apr 22, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/document.rs, components/script/dom/webglcontextevent.rs
  • @emilio: components/script/dom/webglcontextevent.rs
@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 22, 2016

Thanks!

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Apr 22, 2016

📌 Commit 0b5e6bd has been approved by Ms2ger

@jdm
Copy link
Member

jdm commented Apr 22, 2016

@bors-serso r-
./mach test-tidy doesn't pass yet according to TravisCI.

@emilio
Copy link
Member

emilio commented Apr 22, 2016

@bors-servo: r-

(Josh mispelled the bot name)

@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 22, 2016

So it seems:

./components/script/dom/document.rs:81: use statement is not in alphabetical order
    expected: dom::window::{ReflowReason, Window}
    found: dom::webglcontextevent::WebGLContextEvent
./components/script/dom/webglcontextevent.rs:44: extra space before :
@jdm jdm assigned Ms2ger and unassigned pcwalton Apr 22, 2016
@tylersouthwick tylersouthwick force-pushed the tylersouthwick:webglcontextevent branch from 0b5e6bd to cba0267 Apr 23, 2016
@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 25, 2016

Thanks!

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2016

📌 Commit cba0267 has been approved by Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2016

Testing commit cba0267 with merge 5920532...

bors-servo added a commit that referenced this pull request Apr 25, 2016
implement webglcontextevent

fixes #10742

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10805)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2016

@bors-servo bors-servo merged commit cba0267 into servo:master Apr 25, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

7 participants
You can’t perform that action at this time.