Enable webgl tests. #10806

jdm · 2016-04-22T13:37:15Z

…ling ones.

This change is

highfive · 2016-04-22T13:37:18Z

Heads up! This PR modifies the following files:

@jgraham: tests/wpt/include.ini

jdm · 2016-04-22T13:37:35Z

I'm going to run this through try a few times to make sure it doesn't hurt us.

KiChjang · 2016-04-22T16:08:38Z

@bors-servo try

bors-servo · 2016-04-22T16:08:41Z

⌛ Trying commit ad6df6b with merge 832231b...


        Auto merge of #10806 - jdm:webglenable, r=<try>

Enable webgl tests except for known high-frequency intermittently fai… …ling ones.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10806)

bors-servo · 2016-04-22T17:05:55Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt

perlun · 2016-04-22T19:46:18Z

@jdm - this one has gone unmergeable. So maybe this is the answer to your question "what should I work on" 😉

perlun · 2016-04-22T19:47:05Z

(but ah, like you said, perhaps waiting to let other stuff get merged might be pretty neat anyway.)

emilio · 2016-04-22T19:47:17Z

...s/wpt/metadata/webgl/conformance-1.0.3/conformance/more/functions/bufferDataBadArgs.html.ini

@@ -1,5 +1,6 @@
 [bufferDataBadArgs.html]
  type: testharness
+  disabled: https://github.com/servo/servo/issues/10660


This should not be intermittent anymore after #10443.

dzbarsky · 2016-04-23T06:42:14Z

tests/wpt/include.ini

@@ -39,6 +39,8 @@ skip: true
        skip: false
 [cors]
  skip: false
+[webgl]


o.o i'm confused, we're definitely running these tests already...

They were disabled again by @Ms2ger, since they caused a lot of intermittents :/

jdm · 2016-04-23T11:55:50Z

@bors-servo try

jdm · 2016-04-23T13:55:33Z

@bors-servo: try

bors-servo · 2016-04-23T13:55:36Z

⌛ Trying commit 6b91158 with merge 4089742...


        Auto merge of #10806 - jdm:webglenable, r=<try>

Enable webgl tests except for known high-frequency intermittently fai… …ling ones.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10806)

bors-servo · 2016-04-23T14:41:11Z

💔 Test failed - linux-rel

highfive · 2016-04-23T14:41:13Z

  ▶ FAIL [expected PASS] /_mozilla/css/incremental_trailing_whitespace_a.html
  └   → /_mozilla/css/incremental_trailing_whitespace_a.html da54041086f2975f8e3c776d2283ad6609e6862a
/_mozilla/css/incremental_trailing_whitespace_ref.html f5d0147c8bddbdc772a7e5e86c7c9e433fcd486b
Testing da54041086f2975f8e3c776d2283ad6609e6862a == f5d0147c8bddbdc772a7e5e86c7c9e433fcd486b

jdm · 2016-04-23T14:45:59Z

@bors-servo: retry

bors-servo · 2016-04-23T14:46:01Z

⌛ Trying commit 6b91158 with merge 0ba075c...


        Auto merge of #10806 - jdm:webglenable, r=<try>

Enable webgl tests except for known high-frequency intermittently fai… …ling ones.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10806)

bors-servo · 2016-04-23T15:42:56Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt

jdm · 2016-04-23T16:44:34Z

@bors-servo: retry

bors-servo · 2016-04-23T16:44:36Z

⌛ Trying commit 6b91158 with merge bfdd070...

emilio · 2016-04-24T21:28:47Z

@bors-servo: try

(Test expectations might need to get updated after #10670)

KiChjang · 2016-04-25T01:09:41Z

@bors-servo try- retry clean

KiChjang · 2016-04-25T01:10:06Z

@bors-servo try

bors-servo · 2016-04-25T01:10:09Z

⌛ Trying commit 6b91158 with merge e6d9668...


        Auto merge of #10806 - jdm:webglenable, r=<try>

Enable webgl tests. …ling ones.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10806)

bors-servo · 2016-04-25T01:58:46Z

💔 Test failed - mac-rel-wpt

jdm · 2016-04-25T02:03:27Z

  ▶ Unexpected subtest result in /webgl/conformance-1.0.3/conformance/uniforms/uniform-location.html:
  │ FAIL [expected PASS] WebGL test #24: contextA.getUniform(programS, locationSx) should be 3. Threw exception TypeError: contextA.getUniform is not a function
  │   → assert_true: contextA.getUniform(programS, locationSx) should be 3. Threw exception TypeError: contextA.getUniform is not a function expected true got false
  │ 
  │ reportTestResultsToHarness/<@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:87:9
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1397:20
  │ test@http://web-platform.test:8000/resources/testharness.js:495:9
  │ reportTestResultsToHarness@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:86:1
  │ testFailed@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:152:5
  │ shouldBe@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:229:9
  └ @http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/uniforms/uniform-location.html:61:1

  ▶ Unexpected subtest result in /webgl/conformance-1.0.3/conformance/uniforms/uniform-location.html:
  │ FAIL [expected PASS] WebGL test #25: contextA.getUniform(programS, locationArray0) should be 123. Threw exception TypeError: contextA.getUniform is not a function
  │   → assert_true: contextA.getUniform(programS, locationArray0) should be 123. Threw exception TypeError: contextA.getUniform is not a function expected true got false
  │ 
  │ reportTestResultsToHarness/<@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:87:9
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1397:20
  │ test@http://web-platform.test:8000/resources/testharness.js:495:9
  │ reportTestResultsToHarness@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:86:1
  │ testFailed@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:152:5
  │ shouldBe@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:229:9
  └ @http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/uniforms/uniform-location.html:62:1

  ▶ Unexpected subtest result in /webgl/conformance-1.0.3/conformance/uniforms/uniform-location.html:
  │ FAIL [expected PASS] WebGL test #20: getError expected: INVALID_OPERATION. Was NO_ERROR : after evaluating: contextA.uniform1i(locationSx, 3)
  │   → assert_true: getError expected: INVALID_OPERATION. Was NO_ERROR : after evaluating: contextA.uniform1i(locationSx, 3) expected true got false
  │ 
  │ reportTestResultsToHarness/<@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:87:9
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1397:20
  │ test@http://web-platform.test:8000/resources/testharness.js:495:9
  │ reportTestResultsToHarness@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:86:1
  │ testFailed@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:152:5
  │ glErrorShouldBe@http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/resources/webgl-test-utils.js:1379:5
  │ shouldGenerateGLError@http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/resources/webgl-test-utils.js:1355:5
  └ @http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/uniforms/uniform-location.html:51:1

  ▶ Unexpected subtest result in /webgl/conformance-1.0.3/conformance/uniforms/uniform-location.html:
  │ FAIL [expected PASS] WebGL test #21: contextA.getUniform(programS, locationSx) threw exception TypeError: contextA.getUniform is not a function
  │   → assert_true: contextA.getUniform(programS, locationSx) threw exception TypeError: contextA.getUniform is not a function expected true got false
  │ 
  │ reportTestResultsToHarness/<@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:87:9
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1397:20
  │ test@http://web-platform.test:8000/resources/testharness.js:495:9
  │ reportTestResultsToHarness@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:86:1
  │ testFailed@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:152:5
  │ shouldGenerateGLError@http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/resources/webgl-test-utils.js:1353:5
  └ @http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/uniforms/uniform-location.html:52:1


        Enable webgl tests.

jdm · 2016-04-25T21:03:52Z

@bors-servo: r=Ms2ger

bors-servo · 2016-04-25T21:03:54Z

📌 Commit 06dd271 has been approved by Ms2ger

bors-servo · 2016-04-25T22:43:48Z

⌛ Testing commit 06dd271 with merge fee1027...


        Auto merge of #10806 - jdm:webglenable, r=Ms2ger

Enable webgl tests. …ling ones.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10806)

bors-servo · 2016-04-25T23:46:51Z

💔 Test failed - mac-rel-css

highfive · 2016-04-25T23:46:53Z

  ▶ TIMEOUT [expected PASS] /css21_dev/html4/border-spacing-applies-to-016.htm

jdm · 2016-04-26T03:49:13Z

@bors-servo: retry

#10846

bors-servo · 2016-04-26T04:07:27Z

⌛ Testing commit 06dd271 with merge b99e794...


        Auto merge of #10806 - jdm:webglenable, r=Ms2ger

Enable webgl tests. …ling ones.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10806)

bors-servo · 2016-04-26T05:00:23Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt

highfive assigned SimonSapin Apr 22, 2016

highfive added the S-awaiting-review label Apr 22, 2016

jdm assigned jdm and unassigned SimonSapin Apr 22, 2016

jdm added S-awaiting-review and removed S-awaiting-review labels Apr 22, 2016

emilio reviewed Apr 22, 2016
View changes

dzbarsky reviewed Apr 23, 2016
View changes

jdm force-pushed the jdm:webglenable branch from ad6df6b to 6b91158 Apr 23, 2016

highfive added the S-tests-failed label Apr 23, 2016

highfive added the S-tests-failed label Apr 25, 2016

Enable webgl tests.

Loading status checks…

06dd271

jdm force-pushed the jdm:webglenable branch from 6b91158 to 06dd271 Apr 25, 2016

highfive removed the S-tests-failed label Apr 25, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels Apr 25, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Apr 25, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Apr 26, 2016

bors-servo merged commit 06dd271 into servo:master Apr 26, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Apr 26, 2016

autrilla mentioned this pull request May 8, 2016

Added uniform matrix functions (fixes #10671) #11065

Closed

servo / servo

Enable webgl tests. #10806

Enable webgl tests. #10806

jdm commented Apr 22, 2016

highfive commented Apr 22, 2016

jdm commented Apr 22, 2016

KiChjang commented Apr 22, 2016

bors-servo commented Apr 22, 2016

bors-servo commented Apr 22, 2016

perlun commented Apr 22, 2016

perlun commented Apr 22, 2016

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jdm commented Apr 23, 2016

jdm commented Apr 23, 2016

bors-servo commented Apr 23, 2016

bors-servo commented Apr 23, 2016

highfive commented Apr 23, 2016

jdm commented Apr 23, 2016

bors-servo commented Apr 23, 2016

bors-servo commented Apr 23, 2016

jdm commented Apr 23, 2016

bors-servo commented Apr 23, 2016

emilio commented Apr 24, 2016

KiChjang commented Apr 25, 2016

KiChjang commented Apr 25, 2016

bors-servo commented Apr 25, 2016

bors-servo commented Apr 25, 2016

jdm commented Apr 25, 2016

jdm commented Apr 25, 2016

bors-servo commented Apr 25, 2016

bors-servo commented Apr 25, 2016

bors-servo commented Apr 25, 2016

highfive commented Apr 25, 2016

jdm commented Apr 26, 2016

bors-servo commented Apr 26, 2016

bors-servo commented Apr 26, 2016

servo / servo

Join GitHub today

Enable webgl tests. #10806

Enable webgl tests. #10806

Conversation

jdm commented Apr 22, 2016

highfive commented Apr 22, 2016

jdm commented Apr 22, 2016

KiChjang commented Apr 22, 2016

bors-servo commented Apr 22, 2016

bors-servo commented Apr 22, 2016

perlun commented Apr 22, 2016

perlun commented Apr 22, 2016

This comment has been minimized.

emilio Apr 22, 2016

This comment has been minimized.

dzbarsky Apr 23, 2016

This comment has been minimized.

emilio Apr 23, 2016

jdm commented Apr 23, 2016

jdm commented Apr 23, 2016

bors-servo commented Apr 23, 2016

bors-servo commented Apr 23, 2016

highfive commented Apr 23, 2016

jdm commented Apr 23, 2016

bors-servo commented Apr 23, 2016

bors-servo commented Apr 23, 2016

jdm commented Apr 23, 2016

bors-servo commented Apr 23, 2016

emilio commented Apr 24, 2016

KiChjang commented Apr 25, 2016

KiChjang commented Apr 25, 2016

bors-servo commented Apr 25, 2016

bors-servo commented Apr 25, 2016

jdm commented Apr 25, 2016

jdm commented Apr 25, 2016

bors-servo commented Apr 25, 2016

bors-servo commented Apr 25, 2016

bors-servo commented Apr 25, 2016

highfive commented Apr 25, 2016

jdm commented Apr 26, 2016

bors-servo commented Apr 26, 2016

bors-servo commented Apr 26, 2016