Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the svgevents argument to Document::createEvent #10814

Merged
merged 1 commit into from Apr 25, 2016
Merged

Implement the svgevents argument to Document::createEvent #10814

merged 1 commit into from Apr 25, 2016

Conversation

@SunyDays
Copy link
Contributor

SunyDays commented Apr 22, 2016

close #10741

This change is Reviewable
@highfive
Copy link

highfive commented Apr 22, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.
@highfive
Copy link

highfive commented Apr 22, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/document.rs
@highfive
Copy link

highfive commented Apr 22, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@frewsxcv frewsxcv mentioned this pull request Apr 23, 2016
Merged
@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 24, 2016

Lgtm, but we'll need some expectation changes; see tests/wpt/README.md. Let me know if you need help with that.

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2016

⌛ Trying commit 4f38482 with merge b4175ba...
bors-servo added a commit that referenced this pull request Apr 24, 2016
@bors-servo
Auto merge of #10814 - SunyDays:svgevents_argument, r=<try>
Loading status checks…
b4175ba 
Implement the svgevents argument to Document::createEvent

close #10741

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10814)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2016

💔 Test failed - mac-rel-wpt
@highfive
Copy link

highfive commented Apr 24, 2016 

  ▶ Unexpected subtest result in /dom/nodes/Document-createEvent.html:
  └ PASS [expected FAIL] SVGEvents should be an alias for Event.

  ▶ Unexpected subtest result in /dom/nodes/Document-createEvent.html:
  └ PASS [expected FAIL] createEvent(&#39;SVGEvents&#39;) should be initialized correctly.

  ▶ Unexpected subtest result in /dom/nodes/Document-createEvent.html:
  └ PASS [expected FAIL] svgevents should be an alias for Event.

  ▶ Unexpected subtest result in /dom/nodes/Document-createEvent.html:
  └ PASS [expected FAIL] createEvent(&#39;svgevents&#39;) should be initialized correctly.

  ▶ Unexpected subtest result in /dom/nodes/Document-createEvent.html:
  └ PASS [expected FAIL] SVGEVENTS should be an alias for Event.

  ▶ Unexpected subtest result in /dom/nodes/Document-createEvent.html:
  └ PASS [expected FAIL] createEvent(&#39;SVGEVENTS&#39;) should be initialized correctly.
@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 24, 2016

You should remove the parts of the ini file that match those newly passing tests.
@SunyDays
Implement the svgevents argument to Document::createEvent
Loading status checks…
bb19e7d
@KiChjang
Copy link
Member

KiChjang commented Apr 24, 2016

@bors-servo r=Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2016

📌 Commit bb19e7d has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2016

⌛ Testing commit bb19e7d with merge 4b8f126...
bors-servo added a commit that referenced this pull request Apr 25, 2016
@bors-servo
Auto merge of #10814 - SunyDays:svgevents_argument, r=Ms2ger
Loading status checks…
4b8f126 
Implement the svgevents argument to Document::createEvent

close #10741

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10814)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit bb19e7d into servo:master Apr 25, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@SunyDays SunyDays deleted the SunyDays:svgevents_argument branch Apr 25, 2016
@SunyDays SunyDays restored the SunyDays:svgevents_argument branch Apr 25, 2016
@SunyDays SunyDays deleted the SunyDays:svgevents_argument branch Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Implement the "svgevents" argument to Document::createEvent
6 participants
@SunyDays @highfive @Ms2ger @bors-servo @KiChjang @Manishearth
You can’t perform that action at this time.