Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the "focusevent" argument to Document::createEvent #10820

Merged
merged 1 commit into from Apr 27, 2016
Merged

Implement the "focusevent" argument to Document::createEvent #10820

merged 1 commit into from Apr 27, 2016

Conversation

@SunyDays
Copy link
Contributor

SunyDays commented Apr 23, 2016

close #10739

This change is Reviewable
@highfive
Copy link

highfive commented Apr 23, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @SimonSapin (or someone else) soon.
@highfive
Copy link

highfive commented Apr 23, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/document.rs, components/script/dom/focusevent.rs
@highfive
Copy link

highfive commented Apr 23, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2016

☔ The latest upstream changes (presumably #10805) made this pull request unmergeable. Please resolve the merge conflicts.
@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 25, 2016

Thanks for the PR! LGTM with the merge conflicts fixed. Please ping me when you've rebased.
@Ms2ger Ms2ger assigned Ms2ger and unassigned SimonSapin Apr 25, 2016
@jdm jdm removed the S-awaiting-review label Apr 25, 2016
@SunyDays
Implement the focusevent argument to Document::createEvent
Loading status checks…
e4f3a31
@SunyDays
Copy link
Contributor Author

SunyDays commented Apr 26, 2016

@Ms2ger, I'm done
@KiChjang
Copy link
Member

KiChjang commented Apr 26, 2016

@bors-servo r=Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2016

📌 Commit e4f3a31 has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2016

⌛ Testing commit e4f3a31 with merge aa078a0...
bors-servo added a commit that referenced this pull request Apr 27, 2016
@bors-servo
Auto merge of #10820 - SunyDays:focusevent_argument, r=Ms2ger
Loading status checks…
aa078a0 
Implement the "focusevent" argument to Document::createEvent

close #10739

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10820)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo mentioned this pull request Apr 27, 2016
Merged
@bors-servo bors-servo merged commit e4f3a31 into servo:master Apr 27, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced Apr 27, 2016
Merged
Merged
@SunyDays SunyDays deleted the SunyDays:focusevent_argument branch Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Implement the "focusevent" argument to Document::createEvent
7 participants
@SunyDays @highfive @bors-servo @Ms2ger @KiChjang @jdm @SimonSapin
You can’t perform that action at this time.