Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upParse srcset algo #10829
Parse srcset algo #10829
Conversation
highfive
commented
Apr 24, 2016
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @mbrubeck (or someone else) soon. |
highfive
commented
Apr 24, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Apr 24, 2016
|
r? @jdm |
|
Note: I keep changing the labels because I use them as a TODO list for myself. When it's time for me to actually review the code, please speak up :) |
|
|
|
I strongly recommend writing unit tests in the same manner as I described at #10827 (comment), by the way! |
|
@jdm : We've reached till step 9 of parse a source set algorithm, the test tidy passes and the build is successful. Can you please check if the algo written is conceptually correct up till this step? |
|
As far as I can tell, the algorithm makes sense as written. Tests would verify that gut feeling, of course ;) You can implement the EOF condition by matching against the current state after the loop is complete, since that means that the final character was encountered. |
akhan7 commentedApr 24, 2016
Implementing parse a sourceset algorithm
This change is