Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse srcset algo #10829

Closed
wants to merge 10 commits into from
Closed

Parse srcset algo #10829

wants to merge 10 commits into from

Conversation

@akhan7
Copy link
Contributor

akhan7 commented Apr 24, 2016

Implementing parse a sourceset algorithm


This change is Reviewable

srm09 and others added 3 commits Apr 21, 2016
@highfive
Copy link

highfive commented Apr 24, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @mbrubeck (or someone else) soon.

@highfive
Copy link

highfive commented Apr 24, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/net_traits/image_cache_thread.rs, components/net_traits/image_cache_thread.rs, components/script/dom/webidls/HTMLImageElement.webidl, components/script/dom/htmlimageelement.rs, components/net/image_cache_thread.rs
@highfive
Copy link

highfive commented Apr 24, 2016

warning Warning warning

  • These commits modify net and script code, but no tests are modified. Please consider adding a test!
@mbrubeck
Copy link
Contributor

mbrubeck commented Apr 25, 2016

r? @jdm

@highfive highfive assigned jdm and unassigned mbrubeck Apr 25, 2016
@jdm
Copy link
Member

jdm commented Apr 26, 2016

Note: I keep changing the labels because I use them as a TODO list for myself. When it's time for me to actually review the code, please speak up :)

@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2016

The latest upstream changes (presumably #10767) made this pull request unmergeable. Please resolve the merge conflicts.

@jdm
Copy link
Member

jdm commented May 3, 2016

I strongly recommend writing unit tests in the same manner as I described at #10827 (comment), by the way!

aneesh87 and others added 3 commits May 4, 2016
@akhan7
Copy link
Contributor Author

akhan7 commented May 4, 2016

@jdm : We've reached till step 9 of parse a source set algorithm, the test tidy passes and the build is successful. Can you please check if the algo written is conceptually correct up till this step?

@jdm
Copy link
Member

jdm commented May 4, 2016

As far as I can tell, the algorithm makes sense as written. Tests would verify that gut feeling, of course ;) You can implement the EOF condition by matching against the current state after the loop is complete, since that means that the final character was encountered.

@jdm jdm mentioned this pull request May 25, 2016
7 of 7 tasks complete
@jdm
Copy link
Member

jdm commented May 25, 2016

I've noted this work as part of #11416. Thank you for doing it; we have learned more about what is required for implementing this. The lack of tests means that this isn't appropriate to merge right now; we'll return to it as part of #11416.

@jdm jdm closed this May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.